Refine attachment checks in mobile solicitation rule - #5326
Open
randypargman wants to merge 3 commits into
Open
randypargman wants to merge 3 commits into
randypargman wants to merge 3 commits into
Conversation
Update attachment filtering logic to exclude known 3rd party email warning banners.
github-actions
Bot
added
the
review-needed
Contributor
Test Rules Sync - Action RequiredThis PR was not automatically synced to test-rules because the author is not a member of the To enable syncing, an organization member can comment Once triggered, the rules will be synced on the next scheduled run (every 10 minutes). |
Member
|
/update-test-rules |
github-actions
Bot
added
in-test-rules
github-actions Bot
added a commit
that referenced
this pull request
Sep 10, 2026
…t for mobile number via reply thread hijacking
github-actions Bot
added a commit
that referenced
this pull request
Sep 11, 2026
…promise: Request for mobile number via reply thread hijacking
Member
|
shared results from test rules, net new hunt showing no telemetry - hunt |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update attachment filtering logic to exclude known 3rd party email warning banners.
Description
3rd party tools adding warning banners as images rather than text mess with rules that have "zero attachments" logic by adding an attached image warning banner that wasn't part of the original message. This uses a new list of warning banner image SHA256 hashes to exclude those.
In a previous PR, @markmsublime changed it from length(attachments) == 0 (which was causing FN) to checking for zero attachments other than images. This PR further refines that to only excluding known email warning banners.