feat: Force labels to lower#84
Open
mitch-hamm wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GCP labels require lowercase keys and values. Previously
var.additional_tagswas passed directly to label fields, which would cause a400 Bad Requestfrom the GCP API if any key or value contained uppercase characters.This change normalizes all label keys and values to lowercase using a
forexpression across:google_storage_bucket.velero(dns-bucket module)google_storage_bucket.tiered_storage(dns-bucket module)google_storage_bucket.loki(dns-bucket module)google_dns_managed_zone.zone(dns-bucket module)module.gkecluster resource labels (main.tf)If
additional_tagsis empty ({}), the expression evaluates to{}and no labels are applied.Test plan
additional_tagsand verify no labels error