Skip to content

Add keep comments to PSYCLONE_OPTS in NEMOv4 and v5 integration tests - #3511

Open
victoria-atkinson wants to merge 3 commits into
masterfrom
keep-comments-nemo-tests
Open

Add keep comments to PSYCLONE_OPTS in NEMOv4 and v5 integration tests#3511
victoria-atkinson wants to merge 3 commits into
masterfrom
keep-comments-nemo-tests

Conversation

@victoria-atkinson

Copy link
Copy Markdown
Collaborator

No description provided.

@codecov

codecov Bot commented Jul 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (b53f147) to head (1e34eeb).

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #3511   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          397       397           
  Lines        55637     55637           
=========================================
  Hits         55637     55637           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@victoria-atkinson

Copy link
Copy Markdown
Collaborator Author

@sergisiso this is ready for review, thank you :)

@sergisiso

Copy link
Copy Markdown
Collaborator

@victoria-atkinson There are several faliures in both, NEMOv4:

NVFORTRAN-S-0155- Array assignment and block WHERE mask expression do not conform (diurnal_bulk.psycloned.f90: 345)
NVFORTRAN-S-0104-Illegal control structure - unterminated WHERE (diurnal_bulk.psycloned.f90: 346)
NVFORTRAN-S-0104-Illegal control structure - mismatched ENDDO (diurnal_bulk.psycloned.f90: 347)
NVFORTRAN-S-0104-Illegal control structure - mismatched ENDDO (diurnal_bulk.psycloned.f90: 348)
NVFORTRAN-S-0104-Illegal control structure - unterminated block IF (diurnal_bulk.psycloned.f90: 341)
  0 inform,   0 warnings,   5 severes, 0 fatal for diurnal_sst_takaya_step

and NEMOv5:

lbcnfd.psycloned.f90:35:19:

   35 |   public :: lbc_nfd, mpp_nfd
      |                   1
Error: Symbol 'lbc_nfd' at (1) has no IMPLICIT type
lbcnfd.psycloned.f90:2516:21:

 2516 |         call lbc_nfd(ztabglo, cd_nat(jf:jf), psgn(jf:jf), 1)  ! North fold boundary condition
      |                     1
......
 3225 |         call lbc_nfd(ztabglo, cd_nat(jf:jf), psgn(jf:jf), 1)  ! North fold boundary condition
      |                     2
Error: Type mismatch between actual argument at (1) and actual argument at (2) (TYPE(ptr_4d_sp)/TYPE(ptr_4d_dp)).
lbcnfd.psycloned.f90:2516:45:

 2516 |         call lbc_nfd(ztabglo, cd_nat(jf:jf), psgn(jf:jf), 1)  ! North fold boundary condition
      |                                             1
......
 3225 |         call lbc_nfd(ztabglo, cd_nat(jf:jf), psgn(jf:jf), 1)  ! North fold boundary condition
      |                                             2
Error: Type mismatch between actual argument at (1) and actual argument at (2) (REAL(4)/REAL(8)).

We need to understand what is done different than in your local environment.

@sergisiso

Copy link
Copy Markdown
Collaborator

@victoria-atkinson The WHERE fix is merged to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

2 participants