12B: Let the queue that holds the notices say where they are - #23
Open
nikolaystrikhar wants to merge 1 commit into
Open
12B: Let the queue that holds the notices say where they are#23nikolaystrikhar wants to merge 1 commit into
nikolaystrikhar wants to merge 1 commit into
Conversation
Queue::option_name() and Store::option_name() were public static, and public is earned here -- docs/notices.md tells a host to read the option and render the notices itself. Static was not: it answers for the default implementation whatever the site is actually running, so on a site that rebound Queue_Interface to keep notices elsewhere, the documented snippet read an option nothing writes to. It moves onto Queue_Interface as an instance method, so the object a host holds answers for itself, and the docs ask Absorber::notices() for the name. Store keeps the composition, since it is the class that owns the option.
nikolaystrikhar
force-pushed
the
12B-notices-queue-option
branch
from
August 13, 2026 11:01
6e55778 to
98a4426
Compare
d4mation
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: moves
option_name()offNotices\QueueandNotices\Storeas a public static and ontoNotices\Contracts\Queue_Interfaceas an instance method.Usage:
Why this way:
The honest answer depends on which queue the site is running. A static answers for the default implementation whatever is actually bound, so on a site that rebound
Queue_Interfaceto keep notices elsewhere, the snippet indocs/notices.mdread an option nothing writes to.On the contract rather than the default class. The docs invite a host to read the option and render the notices itself, so the object it holds has to be able to answer for itself.
Storekeeps the composition, since it is the class that owns the option.