Change VersionMixConsensus quorum threshold from 3 to 4#368
Merged
marta-lokhova merged 1 commit intomainfrom Apr 16, 2026
Merged
Change VersionMixConsensus quorum threshold from 3 to 4#368marta-lokhova merged 1 commit intomainfrom
marta-lokhova merged 1 commit intomainfrom
Conversation
Copilot
AI
changed the title
[WIP] Update quorum threshold for VersionMixConsensus
Change VersionMixConsensus quorum threshold from 3 to 4
Apr 9, 2026
Contributor
|
@bboston7 this one seemed like a good candidate for Copilot, and looks like it got it! LMK what you think |
There was a problem hiding this comment.
Pull request overview
Updates the versionMixConsensus mission quorum configuration to require full participation from all 4 validators, preventing the network from progressing when a node starts late and would otherwise fall behind permanently.
Changes:
- Update
newCoreSetandoldCoreSetquorum sets to useCoreSetQuorumListWithThreshold(..., 100)(100% threshold). - Set
quorumSetConfigType = RequireExplicitQsetfornewCoreSetto match the explicit configuration used elsewhere in the mission.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bboston7
approved these changes
Apr 16, 2026
marta-lokhova
approved these changes
Apr 16, 2026
Use CoreSetQuorumListWithThreshold with 100% threshold for both newCoreSet and oldCoreSet, requiring all 4 nodes to participate in consensus. This prevents the network from proceeding without a slow pod that could fall behind irrecoverably. Agent-Logs-Url: https://github.com/stellar/supercluster/sessions/fecf9db9-b470-475a-bb58-fa1cde14eb91 Co-authored-by: marta-lokhova <9428003+marta-lokhova@users.noreply.github.com>
marta-lokhova
force-pushed
the
copilot/update-quorum-threshold-to-four
branch
from
9ab4054 to
c31e050
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With 4 validators and the default threshold of 3, the network can proceed if one pod is slow to start. Since these nodes have no history configured, a late-joining node can fall permanently behind.
newCoreSetandoldCoreSetfromCoreSetQuorumListtoCoreSetQuorumListWithThreshold(..., 100), requiring all 4 nodes for consensusquorumSetConfigType = RequireExplicitQsettonewCoreSetfor consistency witholdCoreSet