Skip to content

馃敡 Preserve accurate last-update attribution - #2813

Open
JFWooten4 wants to merge 1 commit into
stellar:mainfrom
JFWooten4:fix-last-updated
Open

馃敡 Preserve accurate last-update attribution#2813
JFWooten4 wants to merge 1 commit into
stellar:mainfrom
JFWooten4:fix-last-updated

Conversation

@JFWooten4

Copy link
Copy Markdown
Contributor

Why

Docusaurus derives each page's last-update author and timestamp from Git history. The production workflow currently checks out only the triggering commit, so that shallow clone's root commit can be attributed to pages it did not modify.

For example, the deployed SDEX page reports a September 2 update by maz, while the latest commit that actually changed the page is 7a80e82bd from July 15 by John Wooten.

What changed

Fetch the complete repository history in the production build-and-push workflow by setting fetch-depth: 0 on the checkout step. This gives Docusaurus the history it needs without changing page content.

Verification

corepack pnpm build completed successfully with full history. The generated SDEX page rendered:

Last updated on Jul 15, 2026 by John Wooten

Co-authored-by: Codex <noreply@openai.com>
Copilot AI balanced review requested due to automatic review settings September 2, 2026 21:36

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the production workflow so Docusaurus can derive accurate page-update attribution from complete Git history.

Changes:

  • Configures checkout with fetch-depth: 0.
  • Documents why full history is required.

馃挕 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@ElliotFriend

Copy link
Copy Markdown
Contributor

that's a pretty good catch, there! let me get our ops team to review, just to double-check there isn't any build performance considerations.

thanks!!

@ElliotFriend
ElliotFriend requested a review from satyamz September 3, 2026 15:50
@satyamz

satyamz commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

@ElliotFriend This will increase build time by couple of seconds and size of the docker image but I do not think this will have any impact in the production since as I understand we just copy build/ directory in the final image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants