馃敡 Preserve accurate last-update attribution - #2813
Open
JFWooten4 wants to merge 1 commit into
Open
Conversation
Co-authored-by: Codex <noreply@openai.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the production workflow so Docusaurus can derive accurate page-update attribution from complete Git history.
Changes:
- Configures checkout with
fetch-depth: 0. - Documents why full history is required.
馃挕 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
|
that's a pretty good catch, there! let me get our ops team to review, just to double-check there isn't any build performance considerations. thanks!! |
Contributor
|
@ElliotFriend This will increase build time by couple of seconds and size of the docker image but I do not think this will have any impact in the production since as I understand we just copy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Docusaurus derives each page's last-update author and timestamp from Git history. The production workflow currently checks out only the triggering commit, so that shallow clone's root commit can be attributed to pages it did not modify.
For example, the deployed SDEX page reports a September 2 update by maz, while the latest commit that actually changed the page is
7a80e82bdfrom July 15 by John Wooten.What changed
Fetch the complete repository history in the production build-and-push workflow by setting
fetch-depth: 0on the checkout step. This gives Docusaurus the history it needs without changing page content.Verification
corepack pnpm buildcompleted successfully with full history. The generated SDEX page rendered: