fix: correct ledger cadence, minimum balance formula, and Horizon status - #2806
Open
ElliotFriend wants to merge 3 commits into
Open
fix: correct ledger cadence, minimum balance formula, and Horizon status#2806ElliotFriend wants to merge 3 commits into
ElliotFriend wants to merge 3 commits into
Conversation
Each correction verified against a primary source, not the reporting issue: - Ledger cadence: a 199-delta Pubnet sample had no close under 5s (median 6s) and CAP-70 targets 5000ms, so "3-5 seconds" was wrong. Now matches the Stellar Stack page. - Minimum balance: Core's getMinBalance excludes selling liabilities, and getAvailableBalance subtracts them separately from v10. Split the two. - Horizon: the canonical pages say deprecation is still ahead, so the present-tense "deprecated" was contradictory. Refs #2805, #2771, #2770 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Corrects three factual inaccuracies, but the minimum-balance formula still incorrectly multiplies “2 base reserves” by baseReserve.
Changes:
- Updates ledger cadence to 5–7 seconds.
- Separates minimum and available balance calculations.
- Clarifies Horizon’s lifecycle status.
Recommendation: NEEDS-CHANGES — correct the remaining minimum-balance formula error.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
docs/validators/README.mdx |
Corrects ledger cadence. |
docs/build/guides/transactions/sponsored-reserves.mdx |
Revises balance formulas. |
docs/learn/migrate/evm/smart-contract-deployment.mdx |
Clarifies Horizon status. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Preview is available here: |
Completes the third part of the sd-043 recommendation, which the previous commit skipped. The Lumens page is where sponsored-reserves sends readers for minimum balance, and it used "available balance" without defining it or mentioning selling liabilities. Also drops "base reserves" from the sponsored-reserves formula, since every other term in the parentheses is a count and the product already multiplies by baseReserve. Refs #2771 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Preview is available here: |
Replaces a comma splice on the Lumens page with the two-sentence construction sponsored-reserves already used, and aligns the middle clause so both pages word the minimum/available balance split the same way. The sd-043 recommendation asked for one definition of each quantity, and two different constructions were working against that. Refs #2771 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Preview is available here: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Three unrelated factual corrections, all filed by Stellar Raven. Each claim was re-verified against a primary source rather than against the issue text.
docs/validators/README.mdxevery 3-5 seconds→every 5-7 secondsbuild/guides/transactions/sponsored-reserves.mdx+ liabilities.sellingfrom the minimum-balance formula, state the available-balance identity insteadlearn/fundamentals/lumens.mdxavailable balancewhere the page first uses the termlearn/migrate/evm/smart-contract-deployment.mdxthe deprecated Horizon API→the Horizon API (nearing end-of-life)Evidence
stellar-stack.mdx. Other cadence mentions in the tree describe the target and are already correct.stellar-core/src/transactions/TransactionUtils.cpp,getMinBalancehas no liabilities term, andgetAvailableBalancesubtracts selling liabilities separately fromProtocolVersion::V_10. They reduce spendable balance, they do not raise the minimum, so a client reproducing the old formula rejects valid transactions whenever the account holds open sell offers. Both pages now state one definition of each quantity:lumens.mdxis where sponsored-reserves sends readers for minimum balance, and it previously used "available balance" without defining it. The formula also drops "base reserves" from the leading2, since every other term in the parentheses is a count and the product already multiplies bybaseReserve.docs/README.mdxalready uses.Left out on purpose
Extracting the Horizon lifecycle sentence into a shared partial (#2770). Worth doing, but it is a refactor across four pages and does not belong in a one-word correction.
Checks
prettier -cclean,check-relative-links.shpasses, fullpnpm buildgreen.Closes #2805
Closes #2771
Closes #2770
🤖 Generated with Claude Code