Skip to content

Comments

bench: refactor to use string interpolation in stats/base/dists/gumbel/ctor#10397

Merged
Planeshifter merged 1 commit intostdlib-js:developfrom
Lokeshranjan8:gamma
Feb 22, 2026
Merged

bench: refactor to use string interpolation in stats/base/dists/gumbel/ctor#10397
Planeshifter merged 1 commit intostdlib-js:developfrom
Lokeshranjan8:gamma

Conversation

@Lokeshranjan8
Copy link
Contributor

Resolves #{{TODO: add issue number}}.

Description

What is the purpose of this pull request?

This pull request:

  • {{TODO: add description describing what this pull request does}}

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

  • #{{TODO: add related issue number}}

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

{{TODO: add disclosure if applicable}}


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Feb 20, 2026
@Lokeshranjan8 Lokeshranjan8 changed the title bench: refactor to use string interpolation in stats/base/dists/gumbe… bench: refactor to use string interpolation in stats/base/dists/gumbel Feb 20, 2026
@Lokeshranjan8 Lokeshranjan8 changed the title bench: refactor to use string interpolation in stats/base/dists/gumbel bench: refactor to use string interpolation in stats/base/dists/gumbel/ctor Feb 20, 2026
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Feb 20, 2026

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/gumbel/ctor $\color{red}486/488$
$\color{green}+0.00%$
$\color{red}33/34$
$\color{green}+0.00%$
$\color{green}19/19$
$\color{green}+0.00%$
$\color{red}486/488$
$\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes themselves look good -- the format import is in the right spot, naming conventions (:: vs :) are preserved, and the refactor is clean.

One thing to fix: the commit message is missing backticks around the package name. Per project convention, it should be:

bench: refactor to use string interpolation in `stats/base/dists/gumbel/ctor`

You can amend the commit to fix this:

git commit --amend -m 'bench: refactor to use string interpolation in `stats/base/dists/gumbel/ctor`'
git push --force

…el/ctor`

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Feb 22, 2026
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Feb 22, 2026
@stdlib-bot
Copy link
Contributor

PR Commit Message

bench: refactor to use string interpolation in `stats/base/dists/gumbel/ctor`

PR-URL: https://github.com/stdlib-js/stdlib/pull/10397

Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit f9c61b1 into stdlib-js:develop Feb 22, 2026
31 checks passed
@stdlib-bot stdlib-bot removed the Ready To Merge A pull request which is ready to be merged. label Feb 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants