Skip to content

Comments

style: disable lint rule#10356

Merged
kgryte merged 2 commits intostdlib-js:developfrom
nickolaif-svg:fix/no-spaces-allowed-parenthesis
Feb 23, 2026
Merged

style: disable lint rule#10356
kgryte merged 2 commits intostdlib-js:developfrom
nickolaif-svg:fix/no-spaces-allowed-parenthesis

Conversation

@nickolaif-svg
Copy link
Contributor

@nickolaif-svg nickolaif-svg commented Feb 19, 2026

Resolves #10355.

Description

This pull request:

This Pull Request was meant to fix a linting error thrown by a formatting error in which a space was placed between an enclosed object's bracket and a function's closing parenthesis

Related Issues

Does this pull request have any related issues?

This pull request:

Fixes JavaScript linting failures detected in the automated lint workflow run

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

bench( 'beep' );
bench( 'boop' );
bench( 'foo', {} );
bench( 'bar', { 'skip': false } );

changed to:

bench( 'beep' );
bench( 'boop' );
bench( 'foo', {} );
bench( 'bar', { 'skip': false });

All linting tests pass locally for this file

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

@stdlib-js/reviewers

@stdlib-bot
Copy link
Contributor

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

Getting Started

Next Steps

  1. A project maintainer will approve GitHub Actions workflows for your PR.
  2. All CI checks must pass before your submission can be fully reviewed.
  3. You'll need to address any failures in linting or unit tests.

Running Tests Locally

You can use make to run any of the CI commands locally from the root directory of the stdlib repository:

# Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"

# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"

If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR.

If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members.

We appreciate your contribution!

Documentation Links

@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot stdlib-bot added First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Needs Review A pull request which needs code review. labels Feb 19, 2026
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Feb 23, 2026
@kgryte kgryte changed the title benchmark: fix bracket spacing style: disable lint rule Feb 23, 2026
@kgryte kgryte added difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. review: 3 labels Feb 23, 2026
@kgryte kgryte merged commit 5df50ac into stdlib-js:develop Feb 23, 2026
50 of 51 checks passed
@stdlib-bot
Copy link
Contributor

Coverage Report

No coverage information available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. review: 3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix JavaScript lint errors

3 participants