Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where long-running processes that render many Antlers views (SSG workers, Octane) get slower with every render.
The
DocumentParseradds every interpolated region it sees toGlobalRuntimeState::$interpolatedVariables, andEnvironment::getValue()checks each string value in a condition against that whole list.resetGlobalState()clears the rest of the runtime state after each request but never this list, so it grows forever in a single process.This PR fixes it by clearing it in
resetGlobalState(). The render node cache is cleared at the same point, so templates get re-parsed and the list fills back up with what the next request needs.Fixes #15814