Repository navigation
[6.x] Keep parsed blueprint and fieldset YAML between requests - #15813
Open
DanielDarrenJones wants to merge 1 commit into
Open
DanielDarrenJones wants to merge 1 commit into
DanielDarrenJones wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blueprint and fieldset files are parsed from YAML on every request that uses them; Blink only keeps them for that request. Page builder blueprints are often tens of kilobytes. Symfony YAML takes about 18 ms to parse an 85 KB one, and reading the parsed array back from a cache takes about 0.05 ms.
Blueprint and fieldset files are now parsed through a small internal
ParsedYamlFilesclass:Benchmark
A generated site on 6.40.0 with an 85 KB page builder blueprint. Each request runs in its own PHP process, as PHP-FPM serves it (boot not timed, opcache on), median of 5, on an M1 Pro with PHP 8.5.
Control panel:
Peak memory on those pages drops by about 2 MB.
On the front end of the same site, page builder pages are 10–12% faster and other pages are within noise. The rendered HTML is unchanged, including after content edits.
I also checked in the CP that changing a blueprint, either in the file or through the blueprint editor, shows up on the next page load.
Tests
ParsedYamlFilesTest:[].The full suite passes.