Repository navigation
[6.x] Keep listing columns when the response doesn't include any - #15801
Open
duncanmcclean wants to merge 1 commit into
Open
duncanmcclean wants to merge 1 commit into
duncanmcclean wants to merge 1 commit into
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-6243b946-6d49-4953-9590-af416f36cc77 Co-authored-by: Duncan McClean <duncan@duncanmcclean.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where clicking a column header on a custom listing would throw
TypeError: can't access property "filter", columns.value is undefined.This was happening because the
Listingcomponent replaces its columns withmeta.columnsfrom every response. Core resources always return them, but custom JSON endpoints (eg. a resource collection in an addon) don't have to. When they're missing, the columns becomeundefinedand anything reading them, like sorting, blows up.This PR fixes it by only replacing the columns when the response actually includes them, otherwise the listing keeps the columns it was given as a prop.