[6.x] Remove stale PHPStan ignore patterns - #15083
Open
duncanmcclean wants to merge 1 commit into
Open
Conversation
PHPStan no longer reports the `valueRetriever()`/`$items` errors for the `keyByWithKey` macro in `CollectionsServiceProvider`, so the ignore patterns for them go unmatched and fail the run. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This was referenced Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request removes two stale PHPStan ignore patterns for
CollectionsServiceProvider. They've been failing CI on multiple pull requests this morning.The patterns were ignoring
method.protected/property.protectederrors for thekeyByWithKeymacro's use ofCollection::valueRetriever()and$items. Neither error is reported any more: PHPStan 2.2.6 resolvesstatic/self/parentrelative to the@param-closure-thisbound class, andMacroable::macro()is annotated with@param-closure-this static $macro, so the closure is now analysed inIlluminate\Support\Collection's own scope — where reaching for its protected internals is perfectly valid.Since
reportUnmatchedIgnoredErrorsis enabled by default, the two now-unmatched patterns fail the run.This PR fixes it by removing them.