Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Problem
ui.cssthat were marked as temporary.-dark-colors were scattered throughout the CP markup and are technically un-themeable, as per Some colors cannot be themed yet #13994What this PR Does
dark:text-whitebecomesdark:text-gray-50;which is almost identical but it's now a theme colorHere is how the old vars are mapped to the new gray vars
dark-* → gray-* replacement swatches
Left: original
--color-dark-*hex. Right: replacement--color-gray-*(theme Zinc).#dfe1e5#d4d4d8#bbbdc0#a1a1aa#93979a#71717a#5f6163#52525b#555759#52525b#515356#3f3f46#4e5157#3f3f46#43454a#3f3f46#414245#3f3f46#404143#3f3f46#3b3f41#27272a#393b40#27272a#2b2d30#27272a#242628#18181b#212223#18181b#22242a#18181b#1e1f22#161618#171717#0f0f10#161616#121214#131314#0a0a0bHow to Reproduce
-dark-color system. Check the "files changed" in this commit to find those.