Skip to content

Verify MCP request isolation and document tracing support - #2656

Open
erichare wants to merge 1 commit into
fix/mcp-command-validationfrom
fix/mcp-request-isolation
Open

erichare wants to merge 1 commit into
fix/mcp-command-validationfrom
fix/mcp-request-isolation

Conversation

@erichare

@erichare erichare commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

What this PR does:

Tests overlapping MCP calls completed in reverse order on one worker. The tests check separate request IDs and callbacks, worker context restoration, and cleanup when one command subscription is canceled. Trace metadata cannot authenticate a request and stays out of responses and logs.

Documents that the current build does not enable OpenTelemetry. Quarkiverse provides the integration, so this PR adds no runtime tracing code. This builds on #2655.

Which issue(s) this PR fixes:

Refs #2629. Enabling distributed tracing and defining allowed baggage keys and size limits remain open.

Verification

19 focused tests passed with 0 failures, 0 errors, and 0 skips on commit e2afa1f02, and formatting checks passed. That is one fewer than before because the serialization-failure logging test left with #2652. The MCP integration suite passed 66 of 66 at fc715181f, which has the same code as the current stack apart from the results guide fix.

JAVA_HOME=/Library/Java/JavaVirtualMachines/graalvm-21.jdk/Contents/Home ./mvnw -B -ntp test '-Dtest=McpLoggingTest,McpResourceTest' -DskipITs -Dxml-format.skip=true -Dquarkus.http.test-port=19080
JAVA_HOME=/Library/Java/JavaVirtualMachines/graalvm-21.jdk/Contents/Home ./mvnw -B -ntp verify -DskipUnitTests '-Dit.test=CollectionCommandToolsMcpIntegrationTest,GeneralCommandToolsMcpIntegrationTest,KeyspaceCommandToolsMcpIntegrationTest,McpFeatureDisabledIntegrationTest,McpLoggingIntegrationTest,McpSchemaIntegrationTest,McpSetupErrorsIntegrationTest,TableCommandToolsMcpIntegrationTest' -Dxml-format.skip=true

Manual client checks were not run. HTTP disconnect cancellation, active distributed tracing, and manual client qualification remain unverified.

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CLA Signed: DataStax CLA

@erichare
erichare requested a review from a team as a code owner October 22, 2026 20:09
@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

📈 Integration Test Coverage Delta vs Main Branch (dse69-it)

Metric Value
Main Branch 73.04%
This PR 73.13%
Delta 🟢 +0.09%
✅ Coverage improved!

@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Integration Test Coverage Report (dse69-it)

Overall Project 73.13% 🍏

There is no coverage information present for the Files changed

@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

📈 Integration Test Coverage Delta vs Main Branch (hcd-it)

Metric Value
Main Branch 74.35%
This PR 74.43%
Delta 🟢 +0.08%
✅ Coverage improved!

@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Integration Test Coverage Report (hcd-it)

Overall Project 74.43% 🍏

There is no coverage information present for the Files changed

@github-actions

github-actions Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

📈 Unit Test Coverage Delta vs Main Branch

Metric Value
Main Branch 55.07%
This PR 56.42%
Delta 🟢 +1.35%
✅ Coverage improved!

@github-actions

github-actions Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Unit Test Coverage Report

Overall Project 56.42% 🍏

There is no coverage information present for the Files changed

@erichare
erichare removed this pull request from stack #2660 October 27, 2026 23:11
@erichare
erichare added this pull request to stack #2667 October 27, 2026 23:12
@erichare
erichare force-pushed the fix/mcp-request-isolation branch from a270ca0 to fc71518 Compare October 27, 2026 23:54
Rebased onto fix/mcp-command-validation without the readable-results change. Tool results keep empty text content, so McpLoggingTest reads the trace status from _meta.
@erichare
erichare force-pushed the fix/mcp-request-isolation branch from fc71518 to e2afa1f Compare October 27, 2026 23:59

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant