Open
Conversation
Stringy
added
ci-all-qa-tests
Contributor
Author
|
/test ocp-4-21-qa-e2e-tests |
Contributor
Author
|
/retest-times 10 ocp-4-21-qa-e2e-tests |
Contributor
🚀 Build Images ReadyImages are ready for commit 31ffd5f. To use with deploy scripts: export MAIN_IMAGE_TAG=4.11.x-778-g31ffd5fea6 |
janisz
reviewed
Apr 24, 2026
Comment on lines
+135
to
138
| def nonFileAccessAlerts = alerts.findAll { !isViolationOfType(it, "FILE_ACCESS") } | ||
| for (alert in nonFileAccessAlerts) { | ||
| validateCimMappings(alert) | ||
| } |
Contributor
There was a problem hiding this comment.
It can be a oneliner
alerts.findAll { !isViolationOfType(it, "FILE_ACCESS") }.each { alert -> validateCimMappings(alert) }
Or even less if we use .& but I've never used it
alerts.findAll { !isViolationOfType(it, "FILE_ACCESS") }.each(this.&validateCimMappings)
janisz
approved these changes
Apr 24, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #20218 +/- ##
=======================================
Coverage 49.79% 49.79%
=======================================
Files 2770 2770
Lines 210212 210212
=======================================
Hits 104667 104667
Misses 97823 97823
Partials 7722 7722
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
/test ocp-4-21-qa-e2e-tests |
3 similar comments
Contributor
|
/test ocp-4-21-qa-e2e-tests |
Contributor
|
/test ocp-4-21-qa-e2e-tests |
Contributor
|
/test ocp-4-21-qa-e2e-tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Further strictness for splunk TA tests, and ensure file access tests resolve violations to avoid contamination of other test suites.
User-facing documentation
Testing and quality
Automated testing
How I validated my change
CI should be enough (with
ci-all-qa-testslabel)