Move MCPServer deletion check before validation and external API calls#4650
Open
qorexdev wants to merge 1 commit intostacklok:mainfrom
Open
Move MCPServer deletion check before validation and external API calls#4650qorexdev wants to merge 1 commit intostacklok:mainfrom
qorexdev wants to merge 1 commit intostacklok:mainfrom
Conversation
During deletion the controller was running 10+ validation steps and external API calls before checking GetDeletionTimestamp(). This meant validation failures could block deletion entirely and unnecessary work was done. Moved the deletion timestamp check and finalizer logic right after fetching the MCPServer resource, before any validation or config handling. Closes stacklok#4631
qorexdev
requested review from
ChrisJBurns,
JAORMX,
jerm-dro,
jhrozek and
yrobla
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
During deletion the MCPServer reconciler runs 10+ validation steps including external API calls (image validation, config fetches, group validation) before checking
GetDeletionTimestamp(). This means validation failures can block deletion entirely and unnecessary work slows down garbage collection.Moved the deletion timestamp check and finalizer logic right after fetching the resource, before any validation or config handling. The new flow is: fetch → check deletion → add finalizer → validate → reconcile.
Fixes #4631
Type of change
Test plan
task test)task lint-fix)No Go toolchain on this machine, relying on CI. The change is a pure code move with no logic modifications.
Does this introduce a user-facing change?
No