refactor: rename McpPort to MCPPort for Go naming conventions#4589
refactor: rename McpPort to MCPPort for Go naming conventions#4589mvanhorn wants to merge 2 commits intostacklok:mainfrom
Conversation
|
@mvanhorn You have an out of date branch/merge conflicts |
Rename the Go struct field McpPort to MCPPort and the method GetMcpPort to GetMCPPort to follow Go convention of all-caps acronyms. JSON tag remains mcpPort (no wire-format change). Closes stacklok#4582
91bcb14 to
9642bfc
Compare
|
Rebased onto current main in 9642bfc. Also caught 3 additional files that upstream changed since the original PR - applied the McpPort -> MCPPort rename to those as well (integration and scaling tests). |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4589 +/- ##
==========================================
- Coverage 68.85% 68.84% -0.01%
==========================================
Files 505 509 +4
Lines 52425 52698 +273
==========================================
+ Hits 36096 36280 +184
- Misses 13536 13614 +78
- Partials 2793 2804 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@mvanhorn there's some CRD steps you need to do. some |
Run `task operator-manifests` and `task crdref-gen` to update generated files with the McpPort -> MCPPort rename from the previous commit. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Ran |
|
@mvanhorn ahhh almost there, we got some lint checks now |
Summary
McpPorttoMCPPortand methodGetMcpPorttoGetMCPPortacross 15 files to follow Go's all-caps acronym conventionmcpPortis unchanged, so no wire-format or API breaking changeTest plan
go build ./cmd/thv-operator/... ./pkg/export/... ./pkg/vmcp/...)Closes #4582