Skip to content

fix(ske): nil pointer when gateway api is not set - #1673

Merged
marceljk merged 7 commits into
mainfrom
fix/ske-gateway-api
Aug 17, 2026
Merged

fix(ske): nil pointer when gateway api is not set#1673
marceljk merged 7 commits into
mainfrom
fix/ske-gateway-api

Conversation

@Manuelvaas

@Manuelvaas Manuelvaas commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Description

fixes:

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see examples/ directory)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Acceptance tests got implemented or updated (see e.g. here)
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@Manuelvaas
Manuelvaas requested a review from a team as a code owner August 7, 2026 16:28
Comment thread stackit/internal/services/ske/cluster/resource.go
@marceljk
marceljk force-pushed the fix/ske-gateway-api branch from 084a6ca to dd9a8af Compare August 14, 2026 11:37
@marceljk
marceljk force-pushed the fix/ske-gateway-api branch from cb629df to c5903c6 Compare August 14, 2026 15:15
@marceljk marceljk added the do-not-merge Do not merge this right now label Aug 14, 2026
@marceljk

marceljk commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Need to be tested first, if the fix works also with projects where the private preview feature is not available.

Update: Tests were successful

@marceljk marceljk removed the do-not-merge Do not merge this right now label Aug 17, 2026
@marceljk
marceljk force-pushed the fix/ske-gateway-api branch from c5903c6 to 5e142c5 Compare August 17, 2026 08:20
@marceljk
marceljk enabled auto-merge (squash) August 17, 2026 08:20
@marceljk
marceljk merged commit 7f98359 into main Aug 17, 2026
3 checks passed
@marceljk
marceljk deleted the fix/ske-gateway-api branch August 17, 2026 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants