Skip to content

feat(mariadb): region adjustment - #1638

Merged
Fyusel merged 1 commit into
mainfrom
region-adjustment-mariadb
Aug 3, 2026
Merged

feat(mariadb): region adjustment#1638
Fyusel merged 1 commit into
mainfrom
region-adjustment-mariadb

Conversation

@Fyusel

@Fyusel Fyusel commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

STACKITTPR-711

Description

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see examples/ directory)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Acceptance tests got implemented or updated (see e.g. here)
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@Fyusel
Fyusel requested a review from a team as a code owner July 31, 2026 07:12

@SerseusWasTaken SerseusWasTaken left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a small nitpick

Comment thread stackit/internal/services/mariadb/credential/datasource.go Outdated
STACKITTPR-711

Signed-off-by: Alexander Dahmen <alexander.dahmen@inovex.de>
@Fyusel
Fyusel force-pushed the region-adjustment-mariadb branch from a04c3ac to 7eeab14 Compare August 3, 2026 06:56
@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/mariadb 0.00% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/mariadb/credential 23.97% (-2.20%) 👎
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/mariadb/instance 20.84% (-1.44%) 👎
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/mariadb/utils 75.00% (-2.78%) 👎

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/mariadb/credential/datasource.go 38.16% (-0.73%) 76 (+4) 29 (+1) 47 (+3) 👎
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/mariadb/credential/resource.go 17.47% (-2.25%) 166 (+24) 29 (+1) 137 (+23) 👎
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/mariadb/instance/datasource.go 0.00% (ø) 45 (+3) 0 45 (+3)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/mariadb/instance/resource.go 23.65% (-1.67%) 334 (+26) 79 (+1) 255 (+25) 👎
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/mariadb/utils/util.go 75.00% (-2.78%) 8 (-1) 6 (-1) 2 👎

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/mariadb/credential/datasource_test.go
  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/mariadb/credential/resource_test.go
  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/mariadb/instance/resource_test.go
  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/mariadb/mariadb_acc_test.go
  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/mariadb/mariadb_test.go
  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/mariadb/utils/util_test.go

@Fyusel
Fyusel merged commit c019c7d into main Aug 3, 2026
3 checks passed
@Fyusel
Fyusel deleted the region-adjustment-mariadb branch August 3, 2026 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants