Feature/waf onboard custom rule group - #1620
Open
Manuelvaas wants to merge 8 commits into
Open
Conversation
SerseusWasTaken
left a comment
SerseusWasTaken
left a comment
Contributor
There was a problem hiding this comment.
look pretty clean, but found an issue during testing:
Using this config:
resource "stackit_alb_waf_custom_rule_group" "custom_rule_group" {
project_id = local.project_id
name = "some-name"
rules = [
{
behavior = {
action = "ACTION_DENY"
log = true
}
conditions = [
{
operator = {
type = "OPERATOR_VALIDATE_UTF8_ENCODING"
value = "dummy"
}
variable = {
type = "VARIABLE_RESPONSE_STATUS"
}
}
]
}
]
}terraform apply runs successfully, but after changing rules[0].behavior.log to false, i got this error:
│ Error: Provider produced inconsistent result after apply
│
│ When applying changes to stackit_alb_waf_custom_rule_group.custom_rule_group, provider "provider[\"registry.terraform.io/stackitcloud/stackit\"]" produced an unexpected new value: .rules[0].behavior.log: was cty.False, but now null.
│
│ This is a bug in the provider, which should be reported in the provider's own issue tracker.
| "rule_id": "Backend auto-allocated unique rule ID within the valid 1-99999 threshold.", | ||
| "behavior_action": "The protective stance action. ACTION_DENY forces a 403 status response code.", | ||
| "behavior_log": "Determines whether an entry should be generated in the security ledger upon a rule hit.", | ||
| "behavior_log_msg": "Custom notification message string mapped to underlying logdata contexts. Required if log is true.", |
Contributor
There was a problem hiding this comment.
Suggested change
| "behavior_log_msg": "Custom notification message string mapped to underlying logdata contexts. Required if log is true.", | |
| "behavior_log_msg": "Custom notification message string mapped to underlying logdata contexts. Required if behavior_log is true.", |
| rules := []RuleModel{} | ||
| diags := model.Rules.ElementsAs(ctx, &rules, true) | ||
| if diags.HasError() { | ||
| return nil, fmt.Errorf("converting to rule map: %v", diags.Errors()) |
Contributor
There was a problem hiding this comment.
Maybe use `core.DiagsToError(diags) here (and at the other instances) instead?
Suggested change
| return nil, fmt.Errorf("converting to rule map: %v", diags.Errors()) | |
| return nil, fmt.Errorf("converting to rule map: %w", core.DiagsToError(diags)) |
Comment on lines
+567
to
+569
| if err != nil || conditions == nil { | ||
| return nil, fmt.Errorf("converting conditions: %w", err) | ||
| } |
Contributor
There was a problem hiding this comment.
Nitpick: given err == nil but conditions != nil this would result in a unhelpful error message. This is highly unlikely to happen though, so feel free to ignore it
| } | ||
|
|
||
| model.Id = tfutils.BuildInternalTerraformId(model.ProjectId.ValueString(), region, model.Name.ValueString()) | ||
| model.Name = types.StringValue(model.Name.ValueString()) |
Contributor
There was a problem hiding this comment.
Shouldn't this rather be something like this?
Suggested change
| model.Name = types.StringValue(model.Name.ValueString()) | |
| model.Name = types.StringValue(*customRuleGroup.Name) |
Merging this branch changes the coverage (1 decrease, 1 increase)
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
relates to STACKITTPR-748
Checklist
make fmtexamples/directory)make generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)