feat(albwaf): onboard WAF - #1612
Open
SerseusWasTaken wants to merge 7 commits into
Open
Conversation
SerseusWasTaken
force-pushed
the
feat/onboard-waf-resource
branch
3 times, most recently
from
July 27, 2026 08:22
6cbea1f to
3a169c3
Compare
SerseusWasTaken
commented
Jul 27, 2026
SerseusWasTaken
force-pushed
the
feat/onboard-waf-resource
branch
3 times, most recently
from
July 28, 2026 05:52
d9fa9f6 to
5b601ad
Compare
marceljk
reviewed
Jul 30, 2026
SerseusWasTaken
force-pushed
the
feat/onboard-waf-resource
branch
from
July 31, 2026 06:50
5b601ad to
ff1b28b
Compare
marceljk
reviewed
Jul 31, 2026
Comment on lines
-25
to
+26
| //go:embed testdata/managed-rule-set.tf | ||
| managedRuleSetConfig string | ||
| //go:embed testdata/resource-max.tf | ||
| wafConfig string |
Contributor
There was a problem hiding this comment.
In the acc tests the resources should be in independent tests. So for the managed rule set, it should remain like before and for the new waf_configuration, there should be a new test terraform config added with a separate test function.
Otherwise it will be difficult in the future to maintain it, when the test config grows with each new resource. In the new test config for waf_config, you can also add a waf_managed_rule_set. But there you don't need to add checks for the waf_managed_ruleset.
See for example the test configs of kms: https://github.com/stackitcloud/terraform-provider-stackit/tree/770998656083e829003cc3ed1c067739cc3033d3/stackit/internal/services/kms/testdata
Contributor
Author
There was a problem hiding this comment.
I see. I re-added the deleted test and minimized the checks for waf managed rule set from the max test
SerseusWasTaken
force-pushed
the
feat/onboard-waf-resource
branch
3 times, most recently
from
August 3, 2026 05:48
fc9d078 to
1a97b9b
Compare
Relates to STACKITTPR-749
Relates to STACKITTPR-749
Relates to STACKITTPR-749
Relates to STACKITTPR-749
Relates to STACKITTPR-749
Relates to STACKITTPR-749
SerseusWasTaken
force-pushed
the
feat/onboard-waf-resource
branch
from
August 3, 2026 07:55
1a97b9b to
b8e6408
Compare
Merging this branch changes the coverage (1 decrease, 1 increase)
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to STACKITTPR-749
Description
Onboards WAF
Checklist
make fmtexamples/directory)make generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)