Skip to content

chore(sfs): migrate to new SDK structure#1396

Open
GokceGK wants to merge 7 commits intomainfrom
gg/migrate-sfs-to-new-sdk-structure
Open

chore(sfs): migrate to new SDK structure#1396
GokceGK wants to merge 7 commits intomainfrom
gg/migrate-sfs-to-new-sdk-structure

Conversation

@GokceGK
Copy link
Copy Markdown
Contributor

@GokceGK GokceGK commented Apr 29, 2026

Description

relates to STACKITCLI-359

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see e.g. here)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@GokceGK GokceGK requested a review from a team as a code owner April 29, 2026 14:08
@github-actions
Copy link
Copy Markdown

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/export-policy/create 52.94% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/export-policy/delete 30.30% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/export-policy/describe 50.00% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/export-policy/list 52.08% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/export-policy/update 51.52% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/performance-class/list 51.35% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/resource-pool/create 54.69% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/resource-pool/delete 38.10% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/resource-pool/describe 61.43% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/resource-pool/list 54.90% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/resource-pool/update 50.82% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/share/create 45.16% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/share/delete 30.43% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/share/describe 50.68% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/share/list 53.70% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/share/update 43.75% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/snapshot/create 48.89% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/snapshot/delete 37.84% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/snapshot/describe 70.21% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/snapshot/list 60.87% (ø)
github.com/stackitcloud/stackit-cli/internal/pkg/services/sfs/client 0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/pkg/services/sfs/utils 83.33% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/export-policy/create/create.go 52.94% (ø) 51 27 24
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/export-policy/delete/delete.go 30.30% (ø) 33 10 23
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/export-policy/describe/describe.go 50.00% (ø) 58 29 29
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/export-policy/list/list.go 52.08% (ø) 48 25 23
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/export-policy/update/update.go 51.52% (ø) 66 34 32
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/performance-class/list/list.go 51.35% (ø) 37 19 18
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/resource-pool/create/create.go 54.69% (ø) 64 35 29
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/resource-pool/delete/delete.go 38.10% (ø) 42 16 26
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/resource-pool/describe/describe.go 61.43% (ø) 70 43 27
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/resource-pool/list/list.go 54.90% (ø) 51 28 23
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/resource-pool/update/update.go 50.82% (ø) 61 31 30
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/share/create/create.go 45.16% (ø) 62 28 34
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/share/delete/delete.go 30.43% (ø) 46 14 32
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/share/describe/describe.go 50.68% (ø) 73 37 36
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/share/list/list.go 53.70% (ø) 54 29 25
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/share/update/update.go 43.75% (ø) 64 28 36
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/snapshot/create/create.go 48.89% (ø) 45 22 23
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/snapshot/delete/delete.go 37.84% (ø) 37 14 23
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/snapshot/describe/describe.go 70.21% (ø) 47 33 14
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/snapshot/list/list.go 60.87% (ø) 46 28 18
github.com/stackitcloud/stackit-cli/internal/pkg/services/sfs/client/client.go 0.00% (ø) 1 0 1
github.com/stackitcloud/stackit-cli/internal/pkg/services/sfs/utils/utils.go 83.33% (ø) 18 15 3

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/export-policy/create/create_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/export-policy/delete/delete_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/export-policy/describe/describe_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/export-policy/list/list_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/export-policy/update/update_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/performance-class/list/list_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/resource-pool/create/create_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/resource-pool/delete/delete_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/resource-pool/describe/describe_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/resource-pool/list/list_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/resource-pool/update/update_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/share/create/create_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/share/delete/delete_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/share/describe/describe_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/share/list/list_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/share/update/update_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/snapshot/create/create_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/snapshot/delete/delete_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/snapshot/describe/describe_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/snapshot/list/list_test.go
  • github.com/stackitcloud/stackit-cli/internal/pkg/services/sfs/utils/utils_test.go

Example: examples.Build(
examples.NewExample(
`Delete a export policy with ID "xxx"`,
`Delete an export policy with ID "xxx"`,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants