fix(load-balancer): print valid JSON/YAML output for list cmds#1382
Merged
rubenhoenle merged 3 commits intomainfrom Apr 28, 2026
Merged
fix(load-balancer): print valid JSON/YAML output for list cmds#1382rubenhoenle merged 3 commits intomainfrom
rubenhoenle merged 3 commits intomainfrom
Conversation
cgoetz-inovex
approved these changes
Apr 27, 2026
…rn valid json/yaml for empty api responses
6bd5bef to
bc5cffd
Compare
Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
relates to STACKITCLI-241 / #893
Testing Instructions
stackit load-balancer list-> Expected: No load balancers found for project "xxx"stackit load-balancer list --output-format json-> Should output valid JSONstackit load-balancer list --output-format yaml-> Should output valid YAMLstackit load-balancer observability-credentials list-> Expected: No observability credentials found for Load Balancer on project "xxx"stackit load-balancer observability-credentials list --output-format json-> Should output valid JSONstackit load-balancer observability-credentials list --output-format yaml-> Should output valid YAMLTest with
--usedflagstackit load-balancer observability-credentials list --used-> Expected: No used observability credentials found for Load Balancer on project "xxx"stackit load-balancer observability-credentials list --output-format json --used-> Should output valid JSONstackit load-balancer observability-credentials list --output-format yaml --used-> Should output valid YAMLTest with
--unusedflagstackit load-balancer observability-credentials list --unused-> Expected: No unused observability credentials found for Load Balancer on project "xxx"stackit load-balancer observability-credentials list --output-format json --unused-> Should output valid JSONstackit load-balancer observability-credentials list --output-format yaml --unused-> Should output valid YAMLChecklist
make fmtmake generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)