Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part of stackabletech/stackable-cockpit#187
This PR adds the
stackable.tech/stackandstackable.tech/demolabels to the various resources produced through the cluster reconciliation if the cluster contains these labels.WIP: This still needs the addition of labels to Clusterroles / ClusterroleBindings deployed by the HDFS Helm Chart. But easier to wait on stackabletech/stackable-cockpit#425 and using that than implementing the same mechanism in this PR.
Changes to the
rust/operator-binary/src/crd/storage.rsandrust/operator-binary/src/event.rsare unrelated, they were suggestions bycargo clippy.In
rust/operator-binary/src/hdfs_controller.rsI reordered the cluster_resources creation/addition to put related code closer together for readability. The order of the cluster_resources itself didn't change.Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker