Update Javadoc for @ActiveProfiles ordering#36950
Open
alexisgra wants to merge 1 commit into
Open
Conversation
Following spring-projectsgh-26004, the registration order of active profiles in @activeprofiles is preserved. The Javadoc in MergedContextConfiguration and WebMergedContextConfiguration still described the old sorting behavior, which is misleading since profile order is part of the context cache key (equals/hashCode). Signed-off-by: Alexis SEGURA <alex.segura06@gmail.com>
spring-projects-issues
added
the
status: waiting-for-triage
sbrannen
added
in: test
sbrannen
changed the title
@ActiveProfiles ordering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
In gh-26004,
TreeSetwas replaced byLinkedHashSetso that the registration order of active profiles in@ActiveProfilesis preserved.However, the Javadoc in MergedContextConfiguration and WebMergedContextConfiguration still described the old sorting behavior. This PR aligns it with the actual behavior.
Active profiles are part of
MergedContextConfigurationequals()andhashCode(), so their order participates in the test context cache key. The previous Javadoc could mislead readers reasoning about why two configurations do or do not share a cachedApplicationContext.I did not find any other occurrences of the outdated doc elsewhere, including in the reference documentation.
Related Issues