Skip to content

scripts: replace /bin/bash with /usr/bin/env bash - #326

Merged
mcopik merged 2 commits into
spcl:masterfrom
valentinkaas:valentinkaas/push-trrpuzwnlpll
Oct 8, 2026
Merged

mcopik merged 2 commits into
spcl:masterfrom
valentinkaas:valentinkaas/push-trrpuzwnlpll

Conversation

@valentinkaas

@valentinkaas valentinkaas commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Chores
    • Updated shell script invocation to use Bash via env, allowing scripts to run in environments where Bash is not located at /bin/bash.

@coderabbitai

coderabbitai Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 9f8c95d6-a82f-49b8-bacb-0b7387bcefde
📥 Commits

Reviewing files that changed from the base of the PR and between b37f475 and f4251d4.

📒 Files selected for processing (3)
  • scripts/clean.sh
  • scripts/pack_code_local.sh
  • sebs/benchmark.py

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.


📝 Walkthrough

Walkthrough

The scripts now select Bash through env instead of using a fixed /bin/bash path. The benchmark code and packaging script also use env bash to launch initialization scripts. Existing arguments and output handling remain unchanged.

Changes

Bash interpreter selection

Layer / File(s) Summary
Select Bash through env
scripts/clean.sh, scripts/pack_code_local.sh, sebs/benchmark.py
The shell scripts use env in their Bash directives. The packaging script and benchmark code launch initialization scripts through env bash; their arguments remain unchanged.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Refactor

Merge Risk: ⚪ Minimal · up to f4251

Scripts now locate Bash through env, which requires Bash to be discoverable via PATH. No documented supported workflow was shown to violate that assumption, so no material merge-blocking failure is established.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 3 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and concisely describes the main change: replacing direct /bin/bash invocation with /usr/bin/env bash in scripts and benchmark initialization.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
🧪 Generate unit tests (beta)
  • Create a new PR
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mcopik

mcopik commented Oct 8, 2026

Copy link
Copy Markdown
Collaborator

Let's merge - simple change, good catch - thanks @valentinkaas! Failing static checks for Azure is likely again our fault in not properly pinning dependencies.

@mcopik
mcopik merged commit 85dd602 into spcl:master Oct 8, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants