Skip to content

Upgrade Sourcemeta dependencies#789

Merged
jviotti merged 2 commits into
mainfrom
new-deps-7
Jul 1, 2026
Merged

Upgrade Sourcemeta dependencies#789
jviotti merged 2 commits into
mainfrom
new-deps-7

Conversation

@jviotti

@jviotti jviotti commented Jul 1, 2026

Copy link
Copy Markdown
Member

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Review in cubic

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 105 files

Re-trigger cubic

@augmentcode

augmentcode Bot commented Jul 1, 2026

Copy link
Copy Markdown
🤖 Augment PR Summary

Summary: This PR updates the repository’s vendored Sourcemeta dependencies (Core/Blaze/JsonBinPack) to newer revisions and aligns local build integration with those upstream changes.

Changes:

  • Bump pinned revisions in top-level and vendored DEPENDENCIES files (Core, Blaze, JsonBinPack).
  • Adjust CMake integration to match new Core options, removing GoogleTest contrib wiring and introducing Core’s new test framework targets.
  • Blaze compiler: refine annotation enabling/collection semantics to control applicator short-circuiting.
  • Core HTTP: add http_cache_control_max_age() to parse Cache-Control max-age.
  • Core JSON-LD: add annotation-map driven jsonld_materialize() for expanded JSON-LD output.
  • Core Unicode/Numeric/Text: add UTF-32→UTF-8 encoders, out-of-range numeric errors, ULP-based float equality, and additional text helpers.

Notes: The large diff is primarily upstream vendored code churn (including removal of vendored GoogleTest sources).

🤖 Was this summary useful? React with 👍 or 👎

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 3 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.


auto print_diagnostic(std::string_view message) -> void {
std::size_t start{0};
while (start <= message.size()) {

@augmentcode augmentcode Bot Jul 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vendor/core/src/lang/test/test.cc:48: while (start <= message.size()) will emit an extra empty # diagnostic line if message ends with a trailing newline (since start reaches message.size()). Consider tightening the loop condition so the final iteration doesn’t print a zero-length line.

Severity: low

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

return;
}

found = true;

@augmentcode augmentcode Bot Jul 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vendor/core/src/core/http/cache_control_max_age.cc:32: found is set before validating the parsed max-age value, so a malformed first max-age directive prevents considering any subsequent valid max-age directives in the same header value. Consider only setting found after parsing succeeds (or documenting that a malformed first directive invalidates the whole header).

Severity: medium

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

Comment thread vendor/core/src/core/jsonld/jsonld_materialize.cc
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@jviotti jviotti merged commit 5ee554a into main Jul 1, 2026
15 checks passed
@jviotti jviotti deleted the new-deps-7 branch July 1, 2026 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant