Upgrade Sourcemeta dependencies#789
Conversation
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
🤖 Augment PR SummarySummary: This PR updates the repository’s vendored Sourcemeta dependencies (Core/Blaze/JsonBinPack) to newer revisions and aligns local build integration with those upstream changes. Changes:
Notes: The large diff is primarily upstream vendored code churn (including removal of vendored GoogleTest sources). 🤖 Was this summary useful? React with 👍 or 👎 |
|
|
||
| auto print_diagnostic(std::string_view message) -> void { | ||
| std::size_t start{0}; | ||
| while (start <= message.size()) { |
There was a problem hiding this comment.
vendor/core/src/lang/test/test.cc:48: while (start <= message.size()) will emit an extra empty # diagnostic line if message ends with a trailing newline (since start reaches message.size()). Consider tightening the loop condition so the final iteration doesn’t print a zero-length line.
Severity: low
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
| return; | ||
| } | ||
|
|
||
| found = true; |
There was a problem hiding this comment.
vendor/core/src/core/http/cache_control_max_age.cc:32: found is set before validating the parsed max-age value, so a malformed first max-age directive prevents considering any subsequent valid max-age directives in the same header value. Consider only setting found after parsing succeeds (or documenting that a malformed first directive invalidates the whole header).
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
Signed-off-by: Juan Cruz Viotti jv@jviotti.com