Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates terminal width detection to use the newer terminal_size API while keeping stdout/stderr width measurement platform-specific (Unix vs Windows).
Changes:
- Bump
terminal_sizedependency from0.2to0.4. - Refactor terminal-width logic into OS-specific modules and use
terminal_size_of()with stdout/stderr handles/FDs. - Bump crate version to
0.1.6and add a changelog entry.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/width.rs |
Routes width lookup through unix/windows modules behind appropriate cfg gates. |
src/width/unix.rs |
Uses terminal_size_of(stdout().as_fd()) / stderr().as_fd() to measure widths on Unix. |
src/width/windows.rs |
Uses terminal_size_of(stdout().as_handle()) / stderr().as_handle() to measure widths on Windows. |
Cargo.toml |
Bumps crate version to 0.1.6 and updates terminal_size to 0.4. |
NEWS.md |
Adds 0.1.6 release notes mentioning the dependency update. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.