Skip to content

upgrade: jsx-tokenizer package upgrade for Solid 2.0#864

Merged
davedbase merged 5 commits into
solidjs-community:nextfrom
davedbase:update/v2/jsx-tokenizer
Jun 3, 2026
Merged

upgrade: jsx-tokenizer package upgrade for Solid 2.0#864
davedbase merged 5 commits into
solidjs-community:nextfrom
davedbase:update/v2/jsx-tokenizer

Conversation

@davedbase
Copy link
Copy Markdown
Member

@davedbase davedbase commented May 4, 2026

Migrate @solid-primitives/jsx-tokenizer to Solid.js v2.0 (beta.10). Updates peer dependencies to solid-js@^2.0.0-beta.10 and @solidjs/web@^2.0.0-beta.10. Moves isServer and JSX type imports to @solidjs/web, renames ResolvedJSXElementResolvedElement, and updates renderToString in the SSR test. Fixes the reactive children test for Solid 2.0's owned-scope write restriction by moving signal declaration outside createRoot and adding flush() before assertions. Also adds moduleName: "@solidjs/web" to the shared vitest config so JSX transforms resolve to @solidjs/web instead of the removed solid-js/web subpath — this is a necessary workspace-level fix that unblocks any package with .tsx test files. Bumps the package to v2.0.0.

Summary by CodeRabbit

Release Notes

  • Breaking Changes

    • Requires Solid.js v2.0 (beta.14); major version bump to 2.0.0
    • Renamed ResolvedJSXElement to ResolvedElement
    • Updated import paths for JSX types
    • createEffect requires split compute/apply syntax
    • Context API uses new <MyContext value={...}> syntax
    • classList prop replaced with class
  • New Features

    • Added Storybook stories demonstrating library usage with interactive examples
  • Documentation

    • Updated README examples for Solid.js v2.0 compatibility

@davedbase davedbase added this to the Solid 2.0 Migration milestone May 4, 2026
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 4, 2026

🦋 Changeset detected

Latest commit: fbc73f1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@solid-primitives/jsx-tokenizer Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@davedbase davedbase marked this pull request as ready for review May 23, 2026 21:14
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 23, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: ccce2345-c1a6-418d-8fec-8554d8fd4a2b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • ✅ Review completed - (🔄 Check again to review again)
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@davedbase davedbase merged commit 39173ce into solidjs-community:next Jun 3, 2026
1 check passed
@davedbase davedbase deleted the update/v2/jsx-tokenizer branch June 3, 2026 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant