Migrate/avoid global state#227
Migrate/avoid global state#227Islam-Shaaban-Ibrahim merged 5 commits intoanalysis_server_migrationfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request migrates the solid_lints package from custom_lint_builder to the analysis_server_plugin framework, refactoring the AvoidGlobalStateRule and updating the test suite. Feedback points out a critical compilation error in the rule registration where the visitor's methods should be passed as tear-offs. Additionally, an improvement was suggested to optimize the mutability check by using the AST directly instead of the element model.
solid-vovabeloded
left a comment
solid-vovabeloded
left a comment
There was a problem hiding this comment.
Great start, @Islam-Shaaban-Ibrahim! I've added a couple of suggestions here - please, take a look.
solid-vovabeloded
left a comment
solid-vovabeloded
left a comment
There was a problem hiding this comment.
Good progress, @Islam-Shaaban-Ibrahim. I have a few more suggestions here and we would be good to go.
solid-vovabeloded
left a comment
solid-vovabeloded
left a comment
There was a problem hiding this comment.
Added two more suggestions, but since they are minor, I'm approving them right away. Feel free to merge it once you apply these suggestions.
Islam-Shaaban-Ibrahim
merged commit 9b70b6e
into
analysis_server_migration
2 participants
Migrate avoid_global_state to analysis_server_plugin