[iOS] Rename fromManual: to fromManualStateChange: in gesture handler API#3996
Merged
akwasniewski merged 2 commits into@akwasniewski/ios-fix-state-manager-beginfrom Feb 25, 2026
Merged
Conversation
…iles Co-authored-by: m-bert <63123542+m-bert@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] WIP address feedback on activation callback for inactive gestures
[iOS] Rename Feb 25, 2026
fromManual: to fromManualStateChange: in gesture handler API
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
fromManual:selector label was ambiguous — it could be confused with the existingmanualActivationflag onRNGestureHandler. Rename it tofromManualStateChange:to clearly convey that this parameter tracks state changes triggered viasetGestureState(the manual state manager path), not manual activation.RNGestureHandler.h— updated all three method declarationsRNGestureHandler.mm— updated implementations and all call sitesRNGestureHandlerModule.mm— updatedsetGestureStatecall sites (the only places passingYES)RNFlingHandler,RNHoverHandler,RNLongPressHandler,RNPanHandler,RNPinchHandler,RNRotationHandler,RNTapHandler) — updated forwarding declarations and call sites🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.