feat: Mutability tracking#2390
Draft
aleksanderkatan wants to merge 23 commits intorefactor/naming-cleanupfrom
Draft
feat: Mutability tracking#2390aleksanderkatan wants to merge 23 commits intorefactor/naming-cleanupfrom
aleksanderkatan wants to merge 23 commits intorefactor/naming-cleanupfrom
Conversation
|
pkg.pr.new packages benchmark commit |
📊 Bundle Size Comparison
👀 Notable resultsStatic test results:No major changes. Dynamic test results:
📋 All resultsClick to reveal the results table (350 entries).
If you wish to run a comparison for other, slower bundlers, run the 'Tree-shake test' from the GitHub Actions menu. |
iwoplaza
force-pushed
the
refactor/naming-cleanup
branch
from
d7926fa to
5b7b6eb
Compare
…at/mutability-tracking
Resolution Time Benchmark---
config:
themeVariables:
xyChart:
plotColorPalette: "#E63946, #3B82F6, #059669"
---
xychart
title "Random Branching (🔴 PR | 🔵 main | 🟢 release)"
x-axis "max depth" [1, 2, 3, 4, 5, 6, 7, 8]
y-axis "time (ms)"
line [0.89, 1.87, 3.87, 6.31, 7.93, 10.29, 20.64, 24.69]
line [0.93, 1.85, 4.23, 6.63, 6.92, 8.99, 21.40, 24.66]
line [0.96, 1.89, 4.12, 6.24, 7.68, 11.22, 20.45, 23.73]
---
config:
themeVariables:
xyChart:
plotColorPalette: "#E63946, #3B82F6, #059669"
---
xychart
title "Linear Recursion (🔴 PR | 🔵 main | 🟢 release)"
x-axis "max depth" [1, 2, 3, 4, 5, 6, 7, 8]
y-axis "time (ms)"
line [0.27, 0.52, 0.65, 0.77, 1.11, 1.11, 1.32, 1.51]
line [0.29, 0.53, 0.70, 0.87, 1.16, 1.25, 1.49, 1.62]
line [0.33, 0.57, 0.71, 0.90, 1.21, 1.25, 1.51, 1.61]
---
config:
themeVariables:
xyChart:
plotColorPalette: "#E63946, #3B82F6, #059669"
---
xychart
title "Full Tree (🔴 PR | 🔵 main | 🟢 release)"
x-axis "max depth" [1, 2, 3, 4, 5, 6, 7, 8]
y-axis "time (ms)"
line [0.97, 2.14, 4.55, 6.52, 12.30, 25.61, 54.33, 111.95]
line [0.75, 1.80, 3.96, 6.04, 12.65, 25.38, 54.02, 111.17]
line [0.73, 1.92, 3.38, 6.10, 12.30, 26.20, 54.05, 112.54]
|
iwoplaza
force-pushed
the
refactor/naming-cleanup
branch
from
5b7b6eb to
2afcfb8
Compare
…at/mutability-tracking
iwoplaza
force-pushed
the
refactor/naming-cleanup
branch
from
2afcfb8 to
d5d4be5
Compare
cieplypolar
reviewed
Apr 17, 2026
Comment on lines
+230
to
239
| if (targetType === snippet.dataType) { | ||
| return snippet; | ||
| } | ||
|
|
||
| return snip( | ||
| snippet.value, | ||
| targetType, | ||
| // if it was a ref, then it's still a ref | ||
| /* origin */ snippet.origin, | ||
| ); |
Collaborator
There was a problem hiding this comment.
Suggested change
| return snippet; |
Collaborator
There was a problem hiding this comment.
I know that I wrote this fragment of code, but now I think this check in unnecessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2356
We could keep and propagate info about unmodified consts (WGSL
const) to handle cases like the below, but I think it is outside the scope of this PR