Repository navigation
Move ext-deepclone version check from Composer conflict to runtime - #172
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #172 +/- ##
============================================
- Coverage 97.45% 97.33% -0.12%
- Complexity 688 692 +4
============================================
Files 75 75
Lines 1648 1653 +5
============================================
+ Hits 1606 1609 +3
- Misses 42 44 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Brajk19
changed the title
Brajk19
marked this pull request as ready for review
September 29, 2026 18:27
HypeMC
previously approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary 📝
purgatory-bundle 2.0.0 can't be installed when the native deepclone extension is loaded
v2 added the conflict
"ext-deepclone": "<0.7.1".symfony/polyfill-deepclonedeclares"provide": {"ext-deepclone": "*"}, and Composer counts that * as matching <0.7.1.we already have runetime check
!\function_exists('deepclone_to_array')but it's not enough because function existed in older version but did not support serializing closures declared in constant expressions (that's what we need for PurgeOn and DynamicValues)Checklist ✅