Skip to content

Use protocol media for response negotiation. - #58

Open
samuel-williams-shopify wants to merge 1 commit into
v3-protocol-applicationfrom
protocol-media-negotiation
Open

Use protocol media for response negotiation.#58
samuel-williams-shopify wants to merge 1 commit into
v3-protocol-applicationfrom
protocol-media-negotiation

Conversation

@samuel-williams-shopify

@samuel-williams-shopify samuel-williams-shopify commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Summary.

  • Use Protocol::Media::Map, Type, and Range for response negotiation.
  • Parse Accept headers with Protocol::HTTP::Header::Accept.
  • Add protocol-media as a runtime dependency.
  • Cover wildcard passthrough registration.

This PR is stacked on #57 and will be rebased onto main after #57 merges.

Verification.

  • 272 tests, 662 assertions.
  • RuboCop passes for the changed files.
  • Documentation coverage: 525/525.

@samuel-williams-shopify
samuel-williams-shopify force-pushed the protocol-media-negotiation branch 2 times, most recently from b934153 to e06d671 Compare August 2, 2026 06:40
@samuel-williams-shopify
samuel-williams-shopify changed the base branch from v3-protocol-application to protocol-application-documentation August 2, 2026 06:40
Base automatically changed from protocol-application-documentation to v3-protocol-application August 2, 2026 06:42
@samuel-williams-shopify
samuel-williams-shopify force-pushed the v3-protocol-application branch 9 times, most recently from 1d4e4e5 to 7507d70 Compare August 2, 2026 12:10
olleolleolle
olleolleolle reviewed Aug 3, 2026
View reviewed changes
Comment thread lib/utopia/controller/responder.rb
media_types = accept.media_ranges.sort
else
media_types = [Handlers::Passthrough::WILDCARD]
end

@olleolleolle olleolleolle Aug 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: Ooh, opportunity to assign from media_types once, from the if-as-expression.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@olleolleolle olleolleolle olleolleolle left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@samuel-williams-shopify @olleolleolle