Move processing heartbeats off the reactor - #8
Open
crmne wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7.
This moves the processing heartbeat / abandoned-job recovery loop off the job reactor and onto a dedicated Ruby thread with its own Redis client.
The important behavior change is that a worker can now continue to own an in-flight job even if the job body temporarily blocks the reactor. Throughput may degrade under blocking workloads, but correctness should not: a still-running job should not look abandoned and be re-executed.
What changed:
ProcessingList#startnow runs the heartbeat/requeue loop in a dedicated thread.Async::Redis::Client, so the liveness path no longer depends on the job reactor yielding.Serverexposes configurableheartbeat_intervalandheartbeat_factoroptions and shuts the heartbeat thread down cleanly.Validation:
bundle exec sus