Repository navigation
Record why received trailers are not marked with trailer! in a SECURITY: comment. - #261
Merged
Merged
Conversation
Contributor
Author
|
Moved the comment from the method documentation into the body, directly above the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a
SECURITY:comment atHTTP2::Stream#receive_trailing_headersrecording that merging received trailers into the headers object withoutHeaders#trailer!was investigated as a smuggling vector and rejected:add(..., trailer: true)admits only fields whose policy permits them as trailers, pseudo-headers are rejected before that, and marking them would drop them from non-chunked responses in a buffering proxy (the reasoning behind closing #259). The open question of theGenericfallback policy is socketry/protocol-http#127.