Skip to content

Wait for HTTP/2 requests to finish - #235

Merged
samuel-williams-shopify merged 1 commit into
mainfrom
wait-for-http2-requests
Jul 29, 2026
Merged

Wait for HTTP/2 requests to finish#235
samuel-williams-shopify merged 1 commit into
mainfrom
wait-for-http2-requests

Conversation

@samuel-williams-shopify

Copy link
Copy Markdown
Contributor

Summary

  • own concurrent HTTP/2 request handlers with an Async::Barrier
  • wait for active handlers before Server#each returns
  • stop remaining handlers if request enumeration exits exceptionally
  • cover queue shutdown while a handler is still active

Testing

  • bundle exec sus test/async/http/protocol/http2/server.rb
  • bundle exec sus (243 passed, 3 skipped)
  • bundle exec rubocop (128 files, no offenses)

This is stacked on #234 because closing the request queue defines when handler draining begins.

Base automatically changed from close-http2-request-queue to main July 29, 2026 06:42
@samuel-williams-shopify
samuel-williams-shopify merged commit fb7e8e5 into main Jul 29, 2026
35 of 46 checks passed
@samuel-williams-shopify
samuel-williams-shopify deleted the wait-for-http2-requests branch July 29, 2026 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant