feat(socket.io): allow passing a Set to to(), in(), and except()#5459
Open
Not-Sarthak wants to merge 1 commit intosocketio:mainfrom
Open
feat(socket.io): allow passing a Set to to(), in(), and except()#5459Not-Sarthak wants to merge 1 commit intosocketio:mainfrom
Not-Sarthak wants to merge 1 commit intosocketio:mainfrom
Conversation
The to(), in(), and except() methods now accept Set<Room> in addition to Room and Room[]. This avoids the need for Array.from() when working with Sets of rooms. Closes socketio#5418
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #5418
The
to(),in(), andexcept()methods now acceptSet<Room>in addition toRoomandRoom[]. This is a natural extension of the array support added in 085d1de.Updated across all entry points:
BroadcastOperator,Namespace,Socket, andServer.Test plan
"emits to rooms with a Set"tsd) pass