chore: preinstall linux acceptance deps in build image#6701
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This comment has been minimized.
This comment has been minimized.
c6e22a0 to
71afe62
Compare
This comment has been minimized.
This comment has been minimized.
I've updated the description. Changes from #6703 were merged here. |
| command: echo all done! | ||
|
|
||
| # this can be removed if we install the xdg-utils package in the docker image | ||
| install-deps-linux-acceptance-tests: |
There was a problem hiding this comment.
@danskmt you need to cleanup of the usage of install-deps-linux-acceptance-tests as well
There was a problem hiding this comment.
yeah I noticed that, thanks! Just pushed removing:
install_deps_extension: linux-acceptance-tests
but kept:
- install-deps-<< parameters.install_deps_extension >>
as it should default to noop in this case.
71afe62 to
39223e6
Compare
PR Reviewer Guide 🔍
|
The image that is being should now contain the dependencies. A separate for installing dependencies is not needed. |
Pull Request Submission Checklist
What does this PR do?
Adds
docker.io,xdg-utils, anduvto.circleci/Dockerfileso Linux acceptance jobs can rely on the build image instead of installing these during CircleCI.Where should the reviewer start?
.circleci/Dockerfile— apt packages anduvinstall for thecircleciuser.circleci/config.yml— uses the new imageHow should this be manually tested?
What's the product update that needs to be communicated to CLI users?
None — internal CI image only.
Risk assessment
Low — slightly larger image and longer build; no CLI behavior change until executor tags are updated.
What are the relevant tickets?
CLI-1443