Open
Conversation
Creating patches for anonymous struct fields
Owner
|
Hey @mitchellkelly, thanks for your contribution—it looks like an interesting use case! If you don’t mind, could you also extend the tests to cover it? (In the meantime I will check the linter issues, I might have to upgrade the test framework) |
Pull Request Test Coverage Report for Build 16197735560Details
💛 - Coveralls |
Author
|
@snorwin I added some tests! Let me know what you think |
Author
|
@snorwin could you review the tests I added? I'm happy to make any necessary changes! |
Merged
Author
|
@snorwin I noticed you mentioned this branch in your coverage PR! Is it possible to merge this ticket in now? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The package currently ignores embedded struct fields so patches wont get created for them. This PR adds the ability to walk embedded structs