Repository navigation
chore: improve no rules found message [DX-5105] - #2853
Conversation
|
👋 Tofel, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
📊 API Diff Results
|
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The CLI documentation contradicts itself about whether datasource-managed rules can produce a kind-specific refusal.
Review effort: Balanced
Findings: 1
What changed in this PR
Improves no-match diagnostics by clarifying which Grafana alert rules are visible and supported.
Changes:
- Scopes available-rule counts to Grafana-managed rules.
- Adds a datasource-managed-rule limitation notice.
- Updates tests, documentation, and release notes.
| File | Description |
|---|---|
grafana-alertcheck/internal/gate/resolve.go |
Enhances no-match errors. |
grafana-alertcheck/internal/gate/resolve_test.go |
Verifies updated diagnostics. |
grafana-alertcheck/docs/reference/cli.md |
Documents no-match behavior. |
grafana-alertcheck/.changeset/v0.1.6.md |
Adds the release note. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
54fd1a3 to
930c1fb
Compare

No description provided.