Skip to content

chore: improve no rules found message [DX-5105] - #2853

Merged
Tofel merged 1 commit into
mainfrom
dx-5105-better-message
Sep 29, 2026
Merged

Tofel merged 1 commit into
mainfrom
dx-5105-better-message

Conversation

@Tofel

@Tofel Tofel commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@Tofel
Tofel requested a review from a team as a code owner September 29, 2026 14:14
Copilot AI balanced review requested due to automatic review settings September 29, 2026 14:14
@github-actions

Copy link
Copy Markdown

👋 Tofel, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@github-actions

github-actions Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

📊 API Diff Results

No changes detected for module github.com/smartcontractkit/chainlink-testing-framework/grafana-alertcheck

View full report

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The CLI documentation contradicts itself about whether datasource-managed rules can produce a kind-specific refusal.

Review effort: Balanced
Findings: 1 Low severity

Open (1)
What changed in this PR

Improves no-match diagnostics by clarifying which Grafana alert rules are visible and supported.

Changes:

  • Scopes available-rule counts to Grafana-managed rules.
  • Adds a datasource-managed-rule limitation notice.
  • Updates tests, documentation, and release notes.
File Description
grafana-alertcheck/​internal/​gate/​resolve.go Enhances no-match errors.
grafana-alertcheck/​internal/​gate/​resolve_test.go Verifies updated diagnostics.
grafana-alertcheck/​docs/​reference/​cli.md Documents no-match behavior.
grafana-alertcheck/​.changeset/​v0.1.6.md Adds the release note.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread grafana-alertcheck/docs/reference/cli.md Outdated
@Tofel
Tofel force-pushed the dx-5105-better-message branch from 54fd1a3 to 930c1fb Compare September 29, 2026 14:19
@Tofel
Tofel enabled auto-merge (squash) September 29, 2026 14:19
@Tofel
Tofel disabled auto-merge September 29, 2026 15:22
@Tofel
Tofel merged commit bdc1679 into main Sep 29, 2026
62 checks passed
@Tofel
Tofel deleted the dx-5105-better-message branch September 29, 2026 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants