Skip to content

feat: add emojis to CLI output - #2852

Merged
Tofel merged 2 commits into
mainfrom
dx-5105-add-emojis-to-output
Sep 29, 2026
Merged

Tofel merged 2 commits into
mainfrom
dx-5105-add-emojis-to-output

Conversation

@Tofel

@Tofel Tofel commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

Make the output a bit cleaner + add emojis:

RESULTS
ALERT                                                                VERDICT  BROKEN FOR  CHECKED EVERY  WINDOW COVERED  DETAILS
[Staging][CRE][Zone-A][Confidential HTTP] Execute Error Rate Spike   healthy  0s          30s            yes
[Staging][CRE][Zone-A][Confidential HTTP] Vault DON Errors Elevated  healthy  0s          30s            yes

LIMITS USED
ALERT                                                                MAX GAP WITHOUT CHECK  QUERY FAILING FOR  NO EVALUATION FOR
[Staging][CRE][Zone-A][Confidential HTTP] Execute Error Rate Spike   1m0s                   1m0s               2m0s
[Staging][CRE][Zone-A][Confidential HTTP] Vault DON Errors Elevated  1m0s                   1m0s               2m0s

Legend:
max gap without check — the longest gap between two checks we accept before we say the alert was not watched.
query failing for — how long Grafana may keep failing to run the alert's query before we stop trusting its state.
no evaluation for — how long Grafana may go without evaluating the alert before we stop trusting its state.

extra watching after your window: +6m0s — so an alert that only starts firing at the end is still caught (slowest: [Staging][CRE][Zone-A][Confidential HTTP] Execute Error Rate Spike (for=5m0s, interval=1m0s))
max wait for all alerts to finish evaluating: 2m0s
clock difference from Grafana: 812ms, accurate to ±238ms (checks fail above 1m0s)

Grafana version: 13.2.1

✅ violations: 0

@Tofel
Tofel requested a review from a team as a code owner September 29, 2026 12:56
Copilot AI balanced review requested due to automatic review settings September 29, 2026 12:56
@github-actions

Copy link
Copy Markdown

👋 Tofel, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@github-actions

github-actions Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

📊 API Diff Results

No changes detected for module github.com/smartcontractkit/chainlink-testing-framework/grafana-alertcheck

View full report

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The formatting changes are consistent, documented, and adequately tested.

Review effort: Balanced
Findings: None

What changed in this PR

Improves Grafana alert-check CLI readability with clearer spacing, labels, and status emojis.

Changes:

  • Adds a Legend: heading and separates the Grafana version.
  • Marks violation totals with ✅ or ❌.
  • Updates tests, documentation, and release notes.
File Description
grafana-alertcheck/​cmd/​table.go Refines CLI footer formatting and status markers.
grafana-alertcheck/​cmd/​table_test.go Tests the revised output and emoji selection.
grafana-alertcheck/​docs/​reference/​cli.md Documents the updated human-readable output.
grafana-alertcheck/​.changeset/​v0.1.5.md Records the user-facing CLI changes.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@Tofel
Tofel merged commit 28b3b74 into main Sep 29, 2026
72 of 74 checks passed
@Tofel
Tofel deleted the dx-5105-add-emojis-to-output branch September 29, 2026 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants