Skip to content

Merge TEE code to main - #437

Merged
nolag merged 9 commits into
mainfrom
rtinianov_teeToMain
Aug 4, 2026
Merged

Merge TEE code to main#437
nolag merged 9 commits into
mainfrom
rtinianov_teeToMain

Conversation

@nolag

@nolag nolag commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

See commits from capabilities dev, already been approved there

@nolag
nolag requested review from a team as code owners August 4, 2026 16:17
@changeset-bot

changeset-bot Bot commented Aug 4, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 22884e5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

👋 nolag, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

vreff
vreff previously approved these changes Aug 4, 2026
@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

The latest Buf updates on your PR. Results from workflow Regenerate Protobuf Files / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed⏩ skippedAug 4, 2026, 7:58 PM

@nolag
nolag enabled auto-merge (squash) August 4, 2026 16:18
Comment thread cre/sdk/v1alpha/sdk.proto Outdated

message CapabilityRestrictions {
repeated CapabilityRestriction restrictions = 1;
int32 max_total_calls = 2;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is still a signed int?

@nolag nolag Aug 4, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matches capabilites dev: https://github.com/smartcontractkit/chainlink-protos/blob/capabilities-development/cre/sdk/v1alpha/sdk.proto#L213

You only changed secrets in #436. I can change this one too, but it would break TEEs using it. Idk there status. That said, the break shouldn't matter since -ve numbers were'nt used.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@russell-stern , what do you want me to do?

Needed for the enclave to forward org identity when fetching
secrets from VaultDON via the confidential relay path.

(cherry picked from commit 5b99921)
russell-stern and others added 5 commits August 4, 2026 14:00
…ies-development

Field 9 is reserved for sdk_execute_request (added on capabilities-development
by a commit not cherry-picked here); restrictions must stay at 10 to match
capabilities-development's wire numbering.
@nolag
nolag merged commit c1accce into main Aug 4, 2026
21 checks passed
@nolag
nolag deleted the rtinianov_teeToMain branch August 4, 2026 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants