Skip to content

wave 1 error improvements#82

Open
wentzeld wants to merge 1 commit intomainfrom
error-messages-wave1
Open

wave 1 error improvements#82
wentzeld wants to merge 1 commit intomainfrom
error-messages-wave1

Conversation

@wentzeld
Copy link

Changes: Fee errors (ErrBumpFeeExceedsLimit, ErrConnectivity, ErrFeeLimitTooLow), multinode ErrNodeError, WriteTarget transmission errors, and corresponding test updates
Dependencies: None
See CRE Error Improvements

@wentzeld wentzeld requested a review from a team as a code owner February 15, 2026 17:30
@github-actions
Copy link

👋 wentzeld, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@jmank88
Copy link
Collaborator

jmank88 commented Feb 18, 2026

IMHO most of these messages are way too verbose for low level errors. They read like high level log messages, by making assumptions about what is going on more broadly and by advising a node operator or a user what to do. This is an inversion of responsibilities - it is the caller's responsibility to determine how to handle low lever errors, and whether to wrap them up with additional details. Some of this information can also exist in documentation rather than as noise in the logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments