Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1636 +/- ##
============================================
- Coverage 73.91% 73.90% -0.01%
+ Complexity 4797 4796 -1
============================================
Files 489 489
Lines 14959 14959
Branches 1562 1562
============================================
- Hits 11057 11056 -1
- Misses 2977 2978 +1
Partials 925 925
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
✅ Update (2026-11-19): reverted, not part of this pull requestThe experimental Original comment (2026-08-25)
|
An ad-hoc runner run merged a full rich Message object into the response_metadata.messages field of every slackLists.* sample (~516 lines each: attachments, bot_profile, wibblr, nested recursion). That field on a slackLists response carries warning strings, not a chat message — the content is bogus and broke PR #1636's diff. Restore all 10 slackLists samples to their main-branch state (clean, empty response_metadata.messages). Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
…ect) The live API returns ai_summary as an object when populated but an empty string when absent, so the earlier String typing failed with "Expected STRING but was BEGIN_OBJECT at path $.ai_summary". Object tolerates both shapes. ❤️ Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Replaces the Object stopgap. Verified against a live files.info call:
ai_summary is a structured object {id, unfurl_enabled, status, content},
or omitted when absent — the live API never returns the empty-string form
(that only appears in generated sample fixtures, which no test parses into
a File), so no custom deserializer is needed: Gson maps omitted -> null and
the object -> AiSummary natively.
❤️
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
…amily The audit test getActions_detectingNewOnes checks each live action against the SDK constants in its matching category class. team_ip_allowlist_range_added was mistakenly placed in Actions.User (next to team_ip_allowlist_access_denied), but the raw audit actions fixture categorizes it under workspace_or_org, so the WorkspaceOrOrg check failed. Moved it there and added the rest of the family the fixture lists (range_removed, enabled, disabled) to pre-empt the same red on subsequent runs. team_ip_allowlist_access_denied correctly stays in User (the fixture lists it under /actions/user). ❤️ Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
❤️ Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
❤️ Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Add the pref.alt_text_reminders action constant to Actions.WorkspaceOrOrg and a typed condition field (AAARuleCondition) to LogsResponse.Details for the app_allowlist_rule_* actions. ❤️ Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Add the pref.canvas_printing_enabled action constant to Actions.WorkspaceOrOrg and a Boolean is_enabled field to LogsResponse.Details. ❤️ Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
…logs Add the pref.canvas_restricted_sharing_enabled action constant to Actions.WorkspaceOrOrg and a String title field to LogsResponse.Details. ❤️ Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Add the pref.disable_email_ingestion action constant to Actions.WorkspaceOrOrg and a List<String> changed_fields field to LogsResponse.Details. ❤️ Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Add the pref.display_email_addresses action constant to Actions.WorkspaceOrOrg. ❤️ Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Add the pref.display_pronouns action constant to Actions.WorkspaceOrOrg. ❤️ Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Co-authored-by: Cheng Chen <35309699+cchensh@users.noreply.github.com> Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
…box, search developer samples, slackbot feedback and traces listed actions to Actions ❤️ Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
The function_inputs map is keyed by each workflow's input names, so the generator now keeps one string input and one credential input under placeholder keys. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
…mples Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
The Luna test app now has two MCP servers, so the first page at limit 1 always has a next cursor. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
The generator replaced every files array with the File model, which dropped the search result fields. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
…published and deleted actions to Actions Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
The recorder now skips them, as it does for audit logs, so live runs no longer overwrite the generated files. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
zimeg
left a comment
There was a problem hiding this comment.
☕ LGTM! The samples keep every property main has, the live values are masked in the generator so they stay out, and the audit gaps from the latest runs are covered.
This PR updates the web API client and model based on the production E2E test results.
Category
Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.