Skip to content

Fix docs: correct Workspace error-throwing behavior for commands and fingerprints#62

Closed
Copilot wants to merge 2 commits intodiagnostic-commandfrom
copilot/sub-pr-61
Closed

Fix docs: correct Workspace error-throwing behavior for commands and fingerprints#62
Copilot wants to merge 2 commits intodiagnostic-commandfrom
copilot/sub-pr-61

Conversation

Copy link
Copy Markdown

Copilot AI commented Mar 2, 2026

Two documentation sections incorrectly described Workspace as silently ignoring invalid inputs when it actually throws.

Changes

  • docs/implementing-a-diagnostic-provider.md: Corrected the description of this.commandsWorkspace throws when a command not declared in that set is executed, it does not ignore it.
  • docs/implementing-a-dismissal-store.md: Updated the addDismissal contract to reflect that Workspace.dismissDiagnostic() throws on null/undefined fingerprints; callers must only pass dismissible diagnostics and store implementations should not expect to receive null/undefined fingerprints via Workspace.

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.


This change is Reviewable

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 2, 2026

⚠️ No Changeset found

Latest commit: 0609eff

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

…rints

Co-authored-by: ddaspit <3261883+ddaspit@users.noreply.github.com>
Copilot AI changed the title [WIP] Update command support in diagnostic providers based on feedback Fix docs: correct Workspace error-throwing behavior for commands and fingerprints Mar 2, 2026
@ddaspit ddaspit closed this Mar 2, 2026
@ddaspit ddaspit deleted the copilot/sub-pr-61 branch March 2, 2026 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants