Fix docs: correct Workspace error-throwing behavior for commands and fingerprints#62
Closed
Copilot wants to merge 2 commits intodiagnostic-commandfrom
Closed
Fix docs: correct Workspace error-throwing behavior for commands and fingerprints#62Copilot wants to merge 2 commits intodiagnostic-commandfrom
Copilot wants to merge 2 commits intodiagnostic-commandfrom
Conversation
|
…rints Co-authored-by: ddaspit <3261883+ddaspit@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update command support in diagnostic providers based on feedback
Fix docs: correct Workspace error-throwing behavior for commands and fingerprints
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two documentation sections incorrectly described
Workspaceas silently ignoring invalid inputs when it actually throws.Changes
docs/implementing-a-diagnostic-provider.md: Corrected the description ofthis.commands—Workspacethrows when a command not declared in that set is executed, it does not ignore it.docs/implementing-a-dismissal-store.md: Updated theaddDismissalcontract to reflect thatWorkspace.dismissDiagnostic()throws onnull/undefinedfingerprints; callers must only pass dismissible diagnostics and store implementations should not expect to receivenull/undefinedfingerprints viaWorkspace.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.
This change is