charlie: faster smoke tests on CI #445

Activity

1. charliecreates commented on May 13, 2026

   

   charliecreatesbot

   on May 13, 2026 – with CharlieCreates

   Contributor

   More actions

   I dug through the current smoke-v2 setup and put together a minimum-change plan (no execution yet) that keeps local behavior intact.

   Current bottleneck

   • CI runs moon smoke-v2:run in .github/workflows/test-smoke-v2.yml.
   • smoke-v2:run depends on smoke-v2:install, which runs playwright install --with-deps (the slow step).

   Proposed plan

   1. Run the smoke-v2 job in the official Playwright container

      • In .github/workflows/test-smoke-v2.yml, set the validate job to use a pinned Playwright image that matches the Playwright package version in test/smoke-v2/package.json.
      • Example: mcr.microsoft.com/playwright:v1.57.0-noble with container options --ipc=host --init.

   2. Add one CI-specific Moon task (small change, no root Moon churn)

      • In test/smoke-v2/moon.yml, add run-ci with:
        • command: playwright test -x
        • deps: setup only
      • Keep existing run task unchanged (setup + install) for local dev.

   3. Use that CI task in workflow

      • In .github/workflows/test-smoke-v2.yml, switch from moon smoke-v2:run to moon smoke-v2:run-ci.

   4. Keep local behavior exactly as-is

      • Local moon smoke-v2:run still performs playwright install --with-deps, so local browser installation remains available.

   Why this is the minimum viable change

   • Only 2 files should need changes:
     • .github/workflows/test-smoke-v2.yml
     • test/smoke-v2/moon.yml
   • No root .moon slopfest.
   • No complicated Moon execution logic.
   • CI avoids the costly Playwright install path by design.

   If you want, I can implement this as a focused PR next.
2. shellscape commented on May 15, 2026

   

   shellscape

   on May 15, 2026

   OwnerAuthor

   More actions

   @CharlieHelps open a new PR which follows the plan in #445 (comment)
3. charliecreates commented on May 15, 2026

   

   charliecreatesbot

   on May 15, 2026 – with CharlieCreates

   Contributor

   More actions

   Opened PR #448 implementing the plan from #445 (comment).

   Changes in this PR:

   • CI validate job now runs in mcr.microsoft.com/playwright:v1.57.0-noble with --ipc=host --init
   • Workflow now runs moon smoke-v2:run-ci
   • Added smoke-v2:run-ci in test/smoke-v2/moon.yml (playwright test -x, deps: setup only)
   • Existing local smoke-v2:run remains unchanged (still includes Playwright install)
4. shellscape

   closed this as completedin #448on May 16, 2026