[codex] Build coding-deepgent local parity baselines#220
Open
kun1s2 wants to merge 239 commits intoshareAI-lab:mainfrom
Open
[codex] Build coding-deepgent local parity baselines#220kun1s2 wants to merge 239 commits intoshareAI-lab:mainfrom
kun1s2 wants to merge 239 commits intoshareAI-lab:mainfrom
Conversation
The OMX team runtime writes local state under .omx/, and worker worktrees require the leader workspace to be clean before launch. Committing the ignore rule preserves local orchestration artifacts outside source control while unblocking durable team execution. Constraint: omx team refuses to launch with a dirty leader workspace because it provisions worker worktrees Rejected: Stash .gitignore before launch | would make .omx/ unignored again during team execution Confidence: high Scope-risk: narrow Directive: Keep .omx/ ignored; do not remove unless replacing the OMX state location Tested: git diff showed only .omx/ ignore addition Not-tested: team launch after commit
The first LangChain milestone needs CI evidence that the parallel s01-s06 track exists, compiles without OpenAI credentials, avoids import-time model starts, and preserves visible teaching harness primitives. This adds the guardrail tests and wires CI through requirements.txt so later LangChain dependency additions are installed consistently. Constraint: Test lane owns tests/CI while code lane still owns agents_langchain implementation Confidence: medium Scope-risk: narrow Tested: python -m py_compile tests/test_langchain_agents_smoke.py; python -m pytest tests/test_agents_smoke.py -q Not-tested: tests/test_langchain_agents_smoke.py passes only after agents_langchain s01-s06 code lane lands
The docs lane needs a stable comparison entry point before the code and test lanes are integrated, so this records where the s01-s06 LangChain/OpenAI-interface track lives, how it should be configured, and how reviewers should keep it separate from the original agents/ baseline and web UI. Constraint: First milestone is s01-s06 only and must preserve agents/ plus web/ boundaries Constraint: LangChain docs currently install core langchain plus langchain-openai for OpenAI integration Rejected: Surface the track through web/ now | user explicitly scoped web UI/app out of this milestone Confidence: high Scope-risk: narrow Tested: python -m pytest tests/test_agents_smoke.py -q; python -m compileall agents tests -q; git diff --check; python -m pip install --dry-run -r requirements.txt pytest Not-tested: full pytest suite due pre-existing tests/test_s_full_background.py failure unrelated to docs/deps changes
The docs lane needs a stable comparison entry point before the code and test lanes are integrated, so this records where the s01-s06 LangChain/OpenAI-interface track lives, how it should be configured, and how reviewers should keep it separate from the original agents/ baseline and web UI. Constraint: First milestone is s01-s06 only and must preserve agents/ plus web/ boundaries Constraint: LangChain docs currently install core langchain plus langchain-openai for OpenAI integration Rejected: Surface the track through web/ now | user explicitly scoped web UI/app out of this milestone Confidence: high Scope-risk: narrow Tested: python -m pytest tests/test_agents_smoke.py -q; python -m compileall agents tests -q; git diff --check; python -m pip install --dry-run -r requirements.txt pytest Not-tested: full pytest suite due pre-existing tests/test_s_full_background.py failure unrelated to docs/deps changes
Add a parallel agents_langchain s01-s06 track so learners can compare the existing hand-written Anthropic SDK baseline against LangChain's OpenAI-interface runtime without changing the web UI or original agents. Constraint: First milestone is s01-s06 only and must preserve agents/*.py plus web/ Rejected: Put LangChain files under agents/ | risks confusing the existing web extractor and baseline teaching boundary Confidence: high Scope-risk: moderate Tested: python -m py_compile agents_langchain/*.py; python -m pytest tests/test_agents_smoke.py tests/test_langchain_agents_smoke.py -q; env -u OPENAI_API_KEY import check for agents_langchain modules
The first LangChain milestone needs to sit beside the hand-written Anthropic SDK lessons, not replace them, so this adds a separate agents_langchain package, non-live smoke tests, OpenAI-style setup docs, and CI dependency wiring while leaving the web app and original s01-s06 scripts unchanged. Constraint: Preserve existing agents/*.py as the baseline and avoid web UI/app changes for this milestone Constraint: Automated tests must not require OPENAI_API_KEY or network access Rejected: Put LangChain files under agents/ | would blur the baseline boundary and risk web extractor churn Confidence: high Scope-risk: moderate Tested: python -m py_compile agents_langchain/*.py tests/test_langchain_agents_smoke.py Tested: python -m pytest tests/test_agents_smoke.py tests/test_langchain_agents_smoke.py -q Tested: env -u OPENAI_API_KEY python -m pytest tests/test_langchain_agents_smoke.py -q Not-tested: Full pytest suite is blocked by pre-existing tests/test_s_full_background.py failure in unmodified agents/s_full.py Not-tested: Live LangChain/OpenAI calls intentionally not run
The integrated LangChain milestone passed its targeted checks, but full repository pytest still failed in BackgroundManagerTests because a running background task with result=None rendered as '[running] None'. Normalizing the None case to the existing running placeholder keeps the capstone behavior aligned with the test and avoids a misleading status string. Constraint: Full post-change verification should pass before concluding the milestone Rejected: Leave the unrelated failure unresolved | would keep full pytest red at handoff time Confidence: high Scope-risk: narrow Directive: Preserve the '(running)' placeholder contract for unfinished background tasks unless tests and user-visible output are updated together Tested: python -m py_compile agents/s_full.py agents_langchain/*.py tests/test_langchain_agents_smoke.py; python -m pytest tests -q Not-tested: Interactive manual run of agents/s_full.py background task commands
added 26 commits
April 19, 2026 23:26
kun1s2
changed the title
Author
|
Release-validation is complete. Current status:\n\n- acceptance circle1: pass\n- acceptance circle2: pass\n- pytest -q coding-deepgent/tests: 438 passed\n- frontend CLI test/typecheck: pass\n- ruff + mypy: pass\n- PR title/body refreshed to current local baseline scope\n- branch rebased/merged with latest upstream main and README conflicts resolved\n\nThe PR is now mergeable from a code/conflict standpoint. The only remaining blockers are repository-side permissions and external Vercel authorization checks. My GitHub identity does not have permission to execute MergePullRequest for this repo, so merge must be completed by a maintainer or someone with merge rights. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Build the current
coding-deepgentlocal parity baselines:Approach A MVPas a verified historical baselineCircle 1local daily-driver parity baselineCircle 2expanded parity baselineThis PR is no longer just an MVP closeout branch. It now represents the current local product baseline for
coding-deepgent.Scope
Historical MVP closeout included on this branch
The branch still contains the earlier Stage 12-29 work:
Circle 1 local daily-driver parity baseline
Implemented on this branch:
coding-deepgent acceptance circle1Circle 2 local expanded parity baseline
Implemented on this branch:
event_streamworker_runtimemailboxteamsorchestration recordsremotesession/control records and replayextension_lifecyclecontinuityartifactscoding-deepgent acceptance circle2What This PR Delivers Now
The branch establishes a coherent local product baseline with:
Explicit Non-Goals / Deferred Beyond This PR
These are still not claimed by the current local baseline:
Reviewer Guide
Recommended review order:
.trellis/project-handoff.md.trellis/plans/coding-deepgent-full-cc-parity-roadmap.md.trellis/plans/coding-deepgent-circle-2-expanded-parity-plan.mdcoding-deepgent/src/coding_deepgent/runtime / session / task / subagent / event / worker / mailbox / team / remote / lifecycle / continuity domainscoding-deepgent/src/coding_deepgent/cli.pyandcli_service.pycoding-deepgent/frontend/cliand frontend bridge protocol updatescoding-deepgent/testsValidation
Current branch validation:
pytest -q coding-deepgent/tests->438 passednpm --prefix coding-deepgent/frontend/cli test-> passednpm --prefix coding-deepgent/frontend/cli run typecheck-> passedruff check coding-deepgent/src/coding_deepgent coding-deepgent/tests .trellis/spec .trellis/plans-> passedpython3 -m mypy coding-deepgent/src/coding_deepgent-> passedPYTHONPATH=coding-deepgent/src python3 -m coding_deepgent acceptance circle1-> passedPYTHONPATH=coding-deepgent/src python3 -m coding_deepgent acceptance circle2-> passedResidual Risks