Skip to content

Document Playwright video proof for UX changes - #429

Open
justin808 wants to merge 1 commit into
mainfrom
jg-codex/playwright-visual-proof-guidance
Open

Document Playwright video proof for UX changes#429
justin808 wants to merge 1 commit into
mainfrom
jg-codex/playwright-visual-proof-guidance

Conversation

@justin808

@justin808 justin808 commented Aug 17, 2026

Copy link
Copy Markdown
Member

Summary

  • add a repository-harness-first Playwright recordVideo fallback for temporal browser evidence
  • require matched baseline/candidate scripts, viewports, and test data with assertion-based waits and inspected, flushed clips
  • align manual-testing, verify-pr-fix, and the canonical durable visual-evidence gate while keeping generated media out of commits

Why

The existing workflow already requires durable before/after evidence and clips for interaction changes, but it did not tell agents how to produce those clips. This adopts the useful operational part of OpenClaw’s visual-proof workflow without copying its repository-specific QA infrastructure or undocumented upload path.

Reference: openclaw/openclaw#122920

Validation

  • ruby skills/pr-batch/bin/hosted-qa-gate-contract-test.rb — 8 runs, 132 assertions, 0 failures
  • bin/validate — pass, including 133 RuboCop-inspected files with no offenses
  • git diff --check — pass

User Impact

Agents verifying UX changes now have a concrete portable recording procedure for paired before/after clips. Static visual changes continue to use screenshots, and consumer-repository browser harnesses remain authoritative.

Summary by CodeRabbit

  • Documentation
    • Updated manual testing guidance to require consistent browser setups, state-based waits, recorded video review, and temporary storage for generated evidence.
    • Expanded pull request verification guidance for documenting temporal browser behavior with paired Playwright recordings, matching test conditions, and asserted UI states.
    • Clarified interaction-evidence workflows, including repository browser harness usage, recording inspection, and proper handling of temporary artifacts.

@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: ded7c585-134f-4483-89ca-96dcb68c91bf

📥 Commits

Reviewing files that changed from the base of the PR and between a48205a and 02129c1.

📒 Files selected for processing (3)
  • skills/manual-testing/SKILL.md
  • skills/verify-pr-fix/SKILL.md
  • workflows/pr-processing.md

Included review availability: Your plan includes up to 1 review per rolling hour; 0 remain after this review.


Walkthrough

Manual testing and PR verification guidance now requires recorded evidence for temporal browser behavior, matching baseline and candidate conditions, state-based waits, recording inspection, and ignored artifact storage.

Changes

Visual evidence guidance

Layer / File(s) Summary
Capture and artifact handling
skills/manual-testing/SKILL.md, skills/verify-pr-fix/SKILL.md, workflows/pr-processing.md
The guidance distinguishes screenshots for static states from paired clips for temporal behavior. It requires matching conditions, asserted waits, flushed recordings, clip inspection, and storage in ignored or temporary directories.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 02129

This PR documents a repository-harness-first procedure for producing paired Playwright video evidence without changing product runtime behavior; no actionable merge-blocking risk remains after normal checks and review.

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: documenting Playwright video evidence for UX changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jg-codex/playwright-visual-proof-guidance

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant